Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 2445533002: Don't suspend the pipeline before HaveFutureData while decoding progressing (Closed)
Patch Set: Use loading progress instead of decoding progress Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/webmediaplayer_impl.h
diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h
index 729d41ec4334c2d0b0c9ab65c59daad4e9fb77ef..8b3b013e45fb69730e4d94cdba917451f4e6f08e 100644
--- a/media/blink/webmediaplayer_impl.h
+++ b/media/blink/webmediaplayer_impl.h
@@ -18,6 +18,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/threading/thread.h"
+#include "base/time/default_tick_clock.h"
#include "base/timer/elapsed_timer.h"
#include "base/timer/timer.h"
#include "build/build_config.h"
@@ -563,6 +564,13 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl
int underflow_count_;
std::unique_ptr<base::ElapsedTimer> underflow_timer_;
+ // The last time didLoadingProgress() returned true.
+ base::TimeTicks last_time_loading_progressed_;
+
+ // Points to |default_tick_clock_| by default, but can be overridden by tests.
+ base::TickClock* tick_clock_;
DaleCurtis 2016/10/28 19:11:42 Nowadays I like just having a single std::unique_p
+ base::DefaultTickClock default_tick_clock_;
+
// Monitors the player events.
base::WeakPtr<MediaObserver> observer_;

Powered by Google App Engine
This is Rietveld 408576698