Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: media/blink/webmediaplayer_delegate.h

Issue 2445533002: Don't suspend the pipeline before HaveFutureData while decoding progressing (Closed)
Patch Set: fix compiler error from rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webmediaplayer_ms.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_delegate.h
diff --git a/media/blink/webmediaplayer_delegate.h b/media/blink/webmediaplayer_delegate.h
index c7b59bd1f1f396b6d8869e0dcbe8251b2987e2fd..62c93bc22dd4339fcd74ae9dcd0dd532cbdba494 100644
--- a/media/blink/webmediaplayer_delegate.h
+++ b/media/blink/webmediaplayer_delegate.h
@@ -31,7 +31,10 @@ class WebMediaPlayerDelegate {
// it may do some or all of the same actions as when |must_suspend| is true.
// To be clear, the player is not required to call PlayerGone() when
// |must_suspend| is false.
- virtual void OnSuspendRequested(bool must_suspend) = 0;
+ // Return false to reject the request and indicate that further calls to
+ // OnSuspendRequested() are required. Otherwise the Observer is removed
+ // from the idle list.
+ virtual bool OnSuspendRequested(bool must_suspend) = 0;
virtual void OnPlay() = 0;
virtual void OnPause() = 0;
« no previous file with comments | « content/renderer/media/webmediaplayer_ms.cc ('k') | media/blink/webmediaplayer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698