Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1857)

Unified Diff: content/renderer/media/renderer_webmediaplayer_delegate.cc

Issue 2445533002: Don't suspend the pipeline before HaveFutureData while decoding progressing (Closed)
Patch Set: fix compiler error from rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/renderer_webmediaplayer_delegate.cc
diff --git a/content/renderer/media/renderer_webmediaplayer_delegate.cc b/content/renderer/media/renderer_webmediaplayer_delegate.cc
index 9660d423724adbd6f0294160d30c869a40ab6399..c7691511ace7cc7c13f2f6429aabbebce2255541 100644
--- a/content/renderer/media/renderer_webmediaplayer_delegate.cc
+++ b/content/renderer/media/renderer_webmediaplayer_delegate.cc
@@ -234,11 +234,12 @@ void RendererWebMediaPlayerDelegate::CleanupIdleDelegates(
const base::TimeTicks now = tick_clock_->NowTicks();
for (auto& idle_delegate_entry : idle_delegate_map_) {
if (now - idle_delegate_entry.second > timeout) {
- id_map_.Lookup(idle_delegate_entry.first)->OnSuspendRequested(false);
-
- // Whether or not the player accepted the suspension, mark it for removal
- // from future polls to avoid running the timer forever.
- idle_delegate_entry.second = base::TimeTicks();
+ if (id_map_.Lookup(idle_delegate_entry.first)
+ ->OnSuspendRequested(false)) {
+ // If the player accepted the suspension, mark it for removal
+ // from future polls to avoid running the timer forever.
+ idle_delegate_entry.second = base::TimeTicks();
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698