content/renderer/media/android/webmediaplayer_android.h - Issue 2445533002: Don't suspend the pipeline before HaveFutureData while decoding progressing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 2445533002: Don't suspend the pipeline before HaveFutureData while decoding progressing (Closed)

Patch Set: fix compiler error from rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/android/webmediaplayer_android.h

diff --git a/content/renderer/media/android/webmediaplayer_android.h b/content/renderer/media/android/webmediaplayer_android.h

index bacb05ab298201fd6346a939c9737f44dda191d3..cd7fa04e132a6b9b3ac93b52e7460a509b7e4bc5 100644

--- a/content/renderer/media/android/webmediaplayer_android.h

+++ b/content/renderer/media/android/webmediaplayer_android.h

@@ -213,7 +213,7 @@ class WebMediaPlayerAndroid

// WebMediaPlayerDelegate::Observer implementation.

void OnHidden() override;

void OnShown() override;

- void OnSuspendRequested(bool must_suspend) override;

+ bool OnSuspendRequested(bool must_suspend) override;

void OnPlay() override;

void OnPause() override;

void OnVolumeMultiplierUpdate(double multiplier) override;