Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2445513002: Remove stl_util's deletion function use from ui/views/. (Closed)

Created:
4 years, 2 months ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion function use from ui/views/. BUG=555865 Committed: https://crrev.com/e3b4782448fa9b79ae51d19ac140dcd97f742922 Cr-Commit-Position: refs/heads/master@{#427084}

Patch Set 1 #

Patch Set 2 : win #

Patch Set 3 : one more #

Patch Set 4 : drop #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -165 lines) Patch
M ui/views/controls/menu/menu_item_view.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/views/controls/menu/native_menu_win.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/native_menu_win.cc View 1 6 chunks +13 lines, -14 lines 0 comments Download
M ui/views/layout/grid_layout.h View 4 chunks +8 lines, -7 lines 0 comments Download
M ui/views/layout/grid_layout.cc View 33 chunks +106 lines, -140 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
Avi (use Gerrit)
4 years, 2 months ago (2016-10-22 21:14:50 UTC) #16
sky
LGTM
4 years, 1 month ago (2016-10-24 15:37:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445513002/60001
4 years, 1 month ago (2016-10-24 15:40:38 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-24 16:34:07 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 16:50:01 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e3b4782448fa9b79ae51d19ac140dcd97f742922
Cr-Commit-Position: refs/heads/master@{#427084}

Powered by Google App Engine
This is Rietveld 408576698