Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2445493002: Capture http to https navigations w/ intent picker (Closed)

Created:
4 years, 2 months ago by Yusuke Sato
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Capture http to https navigations w/ intent picker For navigations from http to https we cannot rely on the Referrer's url since it is cleaned due to the sanitization proccess. For this case we will make use of GetLastCommittedURL(), the main purpose of this information is to decide whether or not to register ArcNavigationThrottle as a candidate to handle a given navigation. BUG=654941 TEST=look at the bug description for repro. Review-Url: https://chromiumcodereview.appspot.com/2436923002 Cr-Commit-Position: refs/heads/master@{#426610} (cherry picked from commit 21236422b54f032ac6a7dcd42d4c8768129f82ae) Committed: https://chromium.googlesource.com/chromium/src/+/10e9dc3198f60a958c62d67062724ca81d9228d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/chromeos/arc/arc_navigation_throttle.cc View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Yusuke Sato
4 years, 2 months ago (2016-10-21 23:15:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10e9dc3198f60a958c62d67062724ca81d9228d3.

Powered by Google App Engine
This is Rietveld 408576698