Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 2445403002: [interpreter] Partially revert handling of --debug-code. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Partially revert handling of --debug-code. This is a partial revert of 438c5eb28bb9 to avoid huge increases in testing times due to expensive bytecode handler generation in debug modes. The additional coverage does not warrant a 2x to 3x increase in testing time at the moment. We can revisit this later. TBR=rmcilroy@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5c57fcce0d58d51ba5eb495ecbc11a618572ff00 Cr-Commit-Position: refs/heads/master@{#40558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445403002/1
4 years, 1 month ago (2016-10-25 11:58:37 UTC) #3
Michael Starzinger
4 years, 1 month ago (2016-10-25 11:58:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 12:00:18 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c57fcce0d58d51ba5eb495ecbc11a618572ff00
Cr-Commit-Position: refs/heads/master@{#40558}

Powered by Google App Engine
This is Rietveld 408576698