Ensure slow properties for simple {__proto__:null} literals.

src/ast/compile-time-value.h

Index: src/ast/compile-time-value.h
diff --git a/src/ast/compile-time-value.h b/src/ast/compile-time-value.h
index d61443e5835e2708a9a82bfb88bdc3489ba21694..2c6a75296d67dd36845b3945ba1d741fad0f0d13 100644
--- a/src/ast/compile-time-value.h
+++ b/src/ast/compile-time-value.h
@@ -17,11 +17,7 @@ class Expression;
 // can be fully handled at compile time.
 class CompileTimeValue : public AllStatic {
  public:
-  enum LiteralType {
-    OBJECT_LITERAL_FAST_ELEMENTS,
-    OBJECT_LITERAL_SLOW_ELEMENTS,
-    ARRAY_LITERAL
-  };
+  static const int kArrayLiteralFlag = -1;

[adamk, 2017/04/26 18:48:15]

This could use a comment, and see below.

[Camillo Bruni, 2017/04/27 09:39:41]

Added comment + DCHECK to better explain the purpose of this value.

 
   static bool IsCompileTimeValue(Expression* expression);
 
@@ -29,7 +25,7 @@ class CompileTimeValue : public AllStatic {
   static Handle<FixedArray> GetValue(Isolate* isolate, Expression* expression);
 
   // Get the type of a compile time value returned by GetValue().

[adamk, 2017/04/26 18:48:14]

Please update this comment to explain what this thing returns. What flags are
these?

[Camillo Bruni, 2017/04/27 09:39:41]

updated with explanation of where the values come from.

-  static LiteralType GetLiteralType(Handle<FixedArray> value);
+  static int GetLiteralTypeFlags(Handle<FixedArray> value);
 
   // Get the elements of a compile time value returned by GetValue().
   static Handle<HeapObject> GetElements(Handle<FixedArray> value);