src/parsing/parser.cc - Issue 2445333002: Ensure slow properties for simple {__proto__:null} literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 2445333002: Ensure slow properties for simple {__proto__:null} literals. (Closed)

Patch Set: addressing nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index 7b7a2aeb6a3ac958ec9ce3be1f8fab16d770ccfb..3f86efac7257cc6b84c7b3eeb58b0a1b60ca65a3 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -4118,7 +4118,7 @@ void Parser::SetFunctionNameFromPropertyName(ObjectLiteralProperty* property,

// Ignore "__proto__" as a name when it's being used to set the [[Prototype]]

// of an object literal.

- if (property->kind() == ObjectLiteralProperty::PROTOTYPE) return;

+ if (property->IsPrototype()) return;

Expression* value = property->value();