Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: test/mjsunit/object-literal.js

Issue 2445333002: Ensure slow properties for simple {__proto__:null} literals. (Closed)
Patch Set: addressing nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax
29
28 var obj = { 30 var obj = {
29 a: 7, 31 a: 7,
30 b: { x: 12, y: 24 }, 32 b: { x: 12, y: 24 },
31 c: 'Zebra' 33 c: 'Zebra'
32 } 34 }
33 35
34 assertEquals(7, obj.a); 36 assertEquals(7, obj.a);
35 assertEquals(12, obj.b.x); 37 assertEquals(12, obj.b.x);
36 assertEquals(24, obj.b.y); 38 assertEquals(24, obj.b.y);
37 assertEquals('Zebra', obj.c); 39 assertEquals('Zebra', obj.c);
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 const prop = 'a'; 296 const prop = 'a';
295 297
296 var p = new Proxy({}, handler); 298 var p = new Proxy({}, handler);
297 p[prop] = 'my value'; 299 p[prop] = 'my value';
298 assertEquals(undefined, p[prop]); 300 assertEquals(undefined, p[prop]);
299 301
300 302
301 var l = new Proxy({[prop]: 'my value'}, handler); 303 var l = new Proxy({[prop]: 'my value'}, handler);
302 assertEquals('my value', l[prop]); 304 assertEquals('my value', l[prop]);
303 })(); 305 })();
306
307 (function TestLiteralWithNullProto() {
308 // Assume dictionary usage for simple null prototype literal objects,
309 // this is equivalent to Object.create(null).
310 var obj = {__proto__:null};
311 assertFalse(%HasFastProperties(obj));
312 assertEquals(Object.getPrototypeOf(obj), null);
313 // Once we add inline properties we probably don't want slow properties
314 // anymore.
315 obj = {__proto__:null, a:1, b:2};
316 assertFalse(%HasFastProperties(obj));
317 assertEquals(Object.getPrototypeOf(obj), null);
318
319 obj = {__proto__: null, ["a"]: 1};
320 assertFalse(%HasFastProperties(obj));
321 assertEquals(Object.getPrototypeOf(obj), null);
322
323 obj = {__proto__: null, a: obj};
324 assertFalse(%HasFastProperties(obj));
325 assertEquals(Object.getPrototypeOf(obj), null);
326
327 obj = {a:1, b:2, __proto__:null};
328 assertFalse(%HasFastProperties(obj));
329 assertEquals(Object.getPrototypeOf(obj), null);
330
331 obj = {["a"]: 1, __proto__: null};
332 assertFalse(%HasFastProperties(obj));
333 assertEquals(Object.getPrototypeOf(obj), null);
334
335 obj = {a: obj, __proto__: null};
336 assertFalse(%HasFastProperties(obj));
337 assertEquals(Object.getPrototypeOf(obj), null);
338 })();
339
340 (function TestSlowLiteralOptimized() {
341 function f() {
342 return {__proto__:null};
343 }
344 let obj = f();
345 assertFalse(%HasFastProperties(obj));
346 assertEquals(Object.getPrototypeOf(obj), null);
347
348 %OptimizeFunctionOnNextCall(f);
349 obj = f();
350 assertFalse(%HasFastProperties(obj));
351 assertEquals(Object.getPrototypeOf(obj), null);
352 })();
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698