third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 2445293003: DevTools: fix wrapping of links in console view

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2445293003: DevTools: fix wrapping of links in console view (Closed)

Patch Set: rename to body, update tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/console/consoleView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index 10ab001b42fb572d3f81910b1b164fed5ca4f067..2a89b1cf3e8c45da135252b2d96407b92ad7124c 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -251,6 +251,7 @@ WebInspector.ConsoleViewMessage.prototype = {

var args = consoleMessage.parameters || [consoleMessage.messageText];

messageElement = this._format(args);

}

+ messageElement.className = "console-message-body";

einbinder 2016/10/25 21:54:08 This kills the classes that might be on messageEle

luoe 2016/10/25 22:52:16 Done.

var formattedMessage = createElement("span");

WebInspector.appendStyle(formattedMessage, "components/objectValue.css");

@@ -308,7 +309,6 @@ WebInspector.ConsoleViewMessage.prototype = {

_buildMessageWithStackTrace: function(consoleMessage, target, linkifier)

{

var toggleElement = createElementWithClass("div", "console-message-stack-trace-toggle");

- var triangleElement = toggleElement.createChild("div", "console-message-stack-trace-triangle");

var contentElement = toggleElement.createChild("div", "console-message-stack-trace-wrapper");

var messageElement = this._buildMessage(consoleMessage);

@@ -340,7 +340,6 @@ WebInspector.ConsoleViewMessage.prototype = {

}

clickableElement.addEventListener("click", toggleStackTrace, false);

- triangleElement.addEventListener("click", toggleStackTrace, false);

if (consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trace)

expandStackTrace(true);