Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2445293003: DevTools: fix wrapping of links in console view (Closed)
Patch Set: rename to body, update tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 var fragment = WebInspector.linkifyStringAsFragmentWithCusto mLinkifier(consoleMessage.messageText, linkifyRequest.bind(consoleMessage)); 244 var fragment = WebInspector.linkifyStringAsFragmentWithCusto mLinkifier(consoleMessage.messageText, linkifyRequest.bind(consoleMessage));
245 messageElement.appendChild(fragment); 245 messageElement.appendChild(fragment);
246 } 246 }
247 } else { 247 } else {
248 messageElement = this._format([consoleMessage.messageText]); 248 messageElement = this._format([consoleMessage.messageText]);
249 } 249 }
250 } else { 250 } else {
251 var args = consoleMessage.parameters || [consoleMessage.messageText] ; 251 var args = consoleMessage.parameters || [consoleMessage.messageText] ;
252 messageElement = this._format(args); 252 messageElement = this._format(args);
253 } 253 }
254 messageElement.className = "console-message-body";
einbinder 2016/10/25 21:54:08 This kills the classes that might be on messageEle
luoe 2016/10/25 22:52:16 Done.
254 255
255 var formattedMessage = createElement("span"); 256 var formattedMessage = createElement("span");
256 WebInspector.appendStyle(formattedMessage, "components/objectValue.css") ; 257 WebInspector.appendStyle(formattedMessage, "components/objectValue.css") ;
257 formattedMessage.className = "console-message-text source-code"; 258 formattedMessage.className = "console-message-text source-code";
258 259
259 var anchorElement = this._buildMessageAnchor(consoleMessage); 260 var anchorElement = this._buildMessageAnchor(consoleMessage);
260 if (anchorElement) 261 if (anchorElement)
261 formattedMessage.appendChild(anchorElement); 262 formattedMessage.appendChild(anchorElement);
262 formattedMessage.appendChild(messageElement); 263 formattedMessage.appendChild(messageElement);
263 return formattedMessage; 264 return formattedMessage;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 302
302 /** 303 /**
303 * @param {!WebInspector.ConsoleMessage} consoleMessage 304 * @param {!WebInspector.ConsoleMessage} consoleMessage
304 * @param {!WebInspector.Target} target 305 * @param {!WebInspector.Target} target
305 * @param {!WebInspector.Linkifier} linkifier 306 * @param {!WebInspector.Linkifier} linkifier
306 * @return {!Element} 307 * @return {!Element}
307 */ 308 */
308 _buildMessageWithStackTrace: function(consoleMessage, target, linkifier) 309 _buildMessageWithStackTrace: function(consoleMessage, target, linkifier)
309 { 310 {
310 var toggleElement = createElementWithClass("div", "console-message-stack -trace-toggle"); 311 var toggleElement = createElementWithClass("div", "console-message-stack -trace-toggle");
311 var triangleElement = toggleElement.createChild("div", "console-message- stack-trace-triangle");
312 var contentElement = toggleElement.createChild("div", "console-message-s tack-trace-wrapper"); 312 var contentElement = toggleElement.createChild("div", "console-message-s tack-trace-wrapper");
313 313
314 var messageElement = this._buildMessage(consoleMessage); 314 var messageElement = this._buildMessage(consoleMessage);
315 var clickableElement = contentElement.createChild("div"); 315 var clickableElement = contentElement.createChild("div");
316 clickableElement.appendChild(messageElement); 316 clickableElement.appendChild(messageElement);
317 var stackTraceElement = contentElement.createChild("div"); 317 var stackTraceElement = contentElement.createChild("div");
318 var stackTracePreview = WebInspector.DOMPresentationUtils.buildStackTrac ePreviewContents(target, linkifier, consoleMessage.stackTrace); 318 var stackTracePreview = WebInspector.DOMPresentationUtils.buildStackTrac ePreviewContents(target, linkifier, consoleMessage.stackTrace);
319 stackTraceElement.appendChild(stackTracePreview); 319 stackTraceElement.appendChild(stackTracePreview);
320 stackTraceElement.classList.add("hidden"); 320 stackTraceElement.classList.add("hidden");
321 321
(...skipping 11 matching lines...) Expand all
333 */ 333 */
334 function toggleStackTrace(event) 334 function toggleStackTrace(event)
335 { 335 {
336 if (event.target.hasSelection()) 336 if (event.target.hasSelection())
337 return; 337 return;
338 expandStackTrace(stackTraceElement.classList.contains("hidden")); 338 expandStackTrace(stackTraceElement.classList.contains("hidden"));
339 event.consume(); 339 event.consume();
340 } 340 }
341 341
342 clickableElement.addEventListener("click", toggleStackTrace, false); 342 clickableElement.addEventListener("click", toggleStackTrace, false);
343 triangleElement.addEventListener("click", toggleStackTrace, false);
344 if (consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trac e) 343 if (consoleMessage.type === WebInspector.ConsoleMessage.MessageType.Trac e)
345 expandStackTrace(true); 344 expandStackTrace(true);
346 345
347 toggleElement._expandStackTraceForTest = expandStackTrace.bind(null, tru e); 346 toggleElement._expandStackTraceForTest = expandStackTrace.bind(null, tru e);
348 return toggleElement; 347 return toggleElement;
349 }, 348 },
350 349
351 /** 350 /**
352 * @param {string} url 351 * @param {string} url
353 * @param {number} lineNumber 352 * @param {number} lineNumber
(...skipping 905 matching lines...) Expand 10 before | Expand all | Expand 10 after
1259 { 1258 {
1260 if (!this._element) { 1259 if (!this._element) {
1261 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this ); 1260 WebInspector.ConsoleViewMessage.prototype.toMessageElement.call(this );
1262 this._element.classList.toggle("collapsed", this._collapsed); 1261 this._element.classList.toggle("collapsed", this._collapsed);
1263 } 1262 }
1264 return this._element; 1263 return this._element;
1265 }, 1264 },
1266 1265
1267 __proto__: WebInspector.ConsoleViewMessage.prototype 1266 __proto__: WebInspector.ConsoleViewMessage.prototype
1268 } 1267 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698