Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2445293003: DevTools: fix wrapping of links in console view (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years, 1 month ago
Reviewers:
einbinder, lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DO NOT COMMIT. This CL was made before a large reformat. Please see the new CL here: https://codereview.chromium.org/2472183002/ DevTools: fix wrapping of links in console view This CL makes link text in the console break on letters. By itself, this could lead to cases where the expansion triangle element is not directly to the left of the message body. Thus, the triangle element has been replaced with a pseudo element on the message body. BUG=658096

Patch Set 1 #

Patch Set 2 : rename to body, update tests #

Patch Set 3 : rename to body, update tests #

Total comments: 2

Patch Set 4 : ac #

Patch Set 5 : rebased #

Total comments: 1

Messages

Total messages: 21 (16 generated)
luoe
4 years, 1 month ago (2016-10-25 20:29:23 UTC) #3
einbinder
https://codereview.chromium.org/2445293003/diff/40001/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2445293003/diff/40001/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode254 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:254: messageElement.className = "console-message-body"; This kills the classes that might ...
4 years, 1 month ago (2016-10-25 21:54:08 UTC) #5
luoe
https://codereview.chromium.org/2445293003/diff/40001/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js File third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js (right): https://codereview.chromium.org/2445293003/diff/40001/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js#newcode254 third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js:254: messageElement.className = "console-message-body"; On 2016/10/25 21:54:08, einbinder wrote: > ...
4 years, 1 month ago (2016-10-25 22:52:16 UTC) #6
einbinder
lgtm
4 years, 1 month ago (2016-10-26 02:59:34 UTC) #7
lushnikov
4 years, 1 month ago (2016-11-03 00:47:30 UTC) #20
https://codereview.chromium.org/2445293003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/console/consoleView.css
(right):

https://codereview.chromium.org/2445293003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/console/consoleView.css:494:
word-wrap: normal;
can we use the .console-message for this? (do we really need this?)

Powered by Google App Engine
This is Rietveld 408576698