Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2445283003: Reland "[heap] Start sweeper tasks after evacuation" (second try). (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "[heap] Start sweeper tasks after evacuation" (second try). This reverts commit 59fb09564a81b30f1d37d68c5fa046e609e23927. BUG=chromium:658718 Committed: https://crrev.com/968caeb44f51ea98c2303d44a7442323fee45ac9 Cr-Commit-Position: refs/heads/master@{#40569}

Patch Set 1 #

Patch Set 2 : bugfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -79 lines) Patch
M src/heap/heap.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 4 chunks +10 lines, -24 lines 0 comments Download
M src/heap/mark-compact.cc View 1 12 chunks +35 lines, -41 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M test/cctest/heap/heap-tester.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M test/cctest/heap/test-page-promotion.cc View 1 2 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ulan
ptal, the diff between PS1&2 contains the fix with regression test.
4 years, 1 month ago (2016-10-25 11:38:17 UTC) #2
Michael Lippautz
lgtm
4 years, 1 month ago (2016-10-25 11:53:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445283003/20001
4 years, 1 month ago (2016-10-25 15:31:56 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 15:34:05 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:12:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/968caeb44f51ea98c2303d44a7442323fee45ac9
Cr-Commit-Position: refs/heads/master@{#40569}

Powered by Google App Engine
This is Rietveld 408576698