[turbofan] Reduce code size for StringFromCharCode.

[turbofan] Reduce code size for StringFromCharCode.

Don't inline the full StringFromCharCode logic into TurboFan, but only
the common case, and use the %StringFromCharCode runtime function for
the rest, similar to what we do in HStringCharFromCode in Crankshaft.
This greatly reduces compile time for TurboFan due to greatly reduced
number of nodes. For example it reduces overall runtime of the base64
benchmark by up to 15% with the future pipeline.

R=yangguo@chromium.org

Committed: https://crrev.com/5a5ffc63e28dbc49e064441ac84950366f5237f0
Cr-Commit-Position: refs/heads/master@{#40544}

[Benedikt Meurer, 2016-10-25 05:17:32]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 05:17:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-10-25 05:18:50]

Hey Yang,

We spend too much time trying to optimize StringFromCharCode (either via
String.fromCharCode or as part of String.prototype.charAt and the element access
on Strings). This makes TurboFan compatible with what Crankshaft does and
greatly reduces compile overhead.
Please take a look.

Thanks,
Benedikt

[Yang, 2016-10-25 05:23:33]

On 2016/10/25 05:18:50, Benedikt Meurer wrote:
> Hey Yang,
> 
> We spend too much time trying to optimize StringFromCharCode (either via
> String.fromCharCode or as part of String.prototype.charAt and the element
access
> on Strings). This makes TurboFan compatible with what Crankshaft does and
> greatly reduces compile overhead.
> Please take a look.
> 
> Thanks,
> Benedikt

lgtm.

[Benedikt Meurer, 2016-10-25 05:57:14]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-10-25 05:57:17]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-10-25 05:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 06:01:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:11:39]

Description was changed from

==========
[turbofan] Reduce code size for StringFromCharCode.

Don't inline the full StringFromCharCode logic into TurboFan, but only
the common case, and use the %StringFromCharCode runtime function for
the rest, similar to what we do in HStringCharFromCode in Crankshaft.
This greatly reduces compile time for TurboFan due to greatly reduced
number of nodes. For example it reduces overall runtime of the base64
benchmark by up to 15% with the future pipeline.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Reduce code size for StringFromCharCode.

Don't inline the full StringFromCharCode logic into TurboFan, but only
the common case, and use the %StringFromCharCode runtime function for
the rest, similar to what we do in HStringCharFromCode in Crankshaft.
This greatly reduces compile time for TurboFan due to greatly reduced
number of nodes. For example it reduces overall runtime of the base64
benchmark by up to 15% with the future pipeline.

R=yangguo@chromium.org

Committed: https://crrev.com/5a5ffc63e28dbc49e064441ac84950366f5237f0
Cr-Commit-Position: refs/heads/master@{#40544}
==========

[commit-bot: I haz the power, 2016-11-17 22:11:40]

Patchset 1 (id:??) landed as
https://crrev.com/5a5ffc63e28dbc49e064441ac84950366f5237f0
Cr-Commit-Position: refs/heads/master@{#40544}