Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2445253002: Fix the issue that the CJK IMEs default mode on the Omnibox is Latin/English. (Closed)

Created:
4 years, 1 month ago by Shu Chen
Modified:
4 years, 1 month ago
Reviewers:
yukawa
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the issue that the CJK IMEs default mode on the Omnibox is Latin/English. BUG=344834 Committed: https://crrev.com/32280ef94afa5d6d8150c63206a035fe37aafc75 Cr-Commit-Position: refs/heads/master@{#427282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/base/ime/input_method_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/base/ime/win/imm32_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Shu Chen
Yohei, can you please review this cl? Thanks.
4 years, 1 month ago (2016-10-25 03:28:01 UTC) #2
yukawa
lgtm
4 years, 1 month ago (2016-10-25 04:00:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445253002/1
4 years, 1 month ago (2016-10-25 05:39:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 05:42:48 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 05:44:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32280ef94afa5d6d8150c63206a035fe37aafc75
Cr-Commit-Position: refs/heads/master@{#427282}

Powered by Google App Engine
This is Rietveld 408576698