Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: test/mjsunit/regress/regress-5559.js

Issue 2445233004: [debugger] fix stepping out of across throwing. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug 5 // Flags: --expose-debug-as debug
6 6
7 Debug = debug.Debug 7 Debug = debug.Debug
8 8
9 var exception = null; 9 var exception = null;
10 var break_count = 0; 10 var break_count = 0;
11 11
12 function listener(event, exec_state, event_data, data) { 12 function listener(event, exec_state, event_data, data) {
13 if (event != Debug.DebugEvent.Break) return; 13 if (event != Debug.DebugEvent.Break) return;
14 try { 14 try {
15 print(event_data.sourceLineText()); 15 print(event_data.sourceLineText());
16 assertTrue( 16 assertTrue(
17 event_data.sourceLineText().indexOf(`Break ${break_count++}.`) > 0); 17 event_data.sourceLineText().indexOf(`Break ${break_count++}.`) > 0);
18 exec_state.prepareStep(Debug.StepAction.StepIn); 18 exec_state.prepareStep(Debug.StepAction.StepFrame);
jgruber 2016/10/25 07:28:54 StepOut as discussed offline.
19 } catch (e) { 19 } catch (e) {
20 exception = e; 20 exception = e;
21 } 21 }
22 }; 22 };
23 23
24 function customSplit() { 24 function thrower() {
25 return "x"; // Break 2. 25 try {
26 } // Break 3. 26 debugger; // Break 0.
27 var o = {}; 27 throw 'error';
28 o[Symbol.split] = customSplit; 28 } catch (err) {
29 }
30 }
31
29 32
30 Debug.setListener(listener); 33 Debug.setListener(listener);
31 debugger; // Break 0. 34 thrower();
32 var result = "".split(o); // Break 1. 35 Debug.setListener(null); // Break 1.
33 Debug.setListener(null); // Break 4.
34 36
35 assertEquals("x", result);
36 assertNull(exception); 37 assertNull(exception);
jgruber 2016/10/25 07:28:54 Should we assertEquals(2, break_count) here?
OLDNEW
« no previous file with comments | « src/debug/debug.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698