Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Issue 2445233004: [debugger] fix stepping out of across throwing. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] fix stepping out of across throwing. R=jgruber@chromium.org BUG=v8:5559 Committed: https://crrev.com/baba15223c3a08f87e69ae5c851bcb215f4048df Cr-Commit-Position: refs/heads/master@{#40549}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -12 lines) Patch
M src/debug/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-5559.js View 1 2 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Yang
4 years, 1 month ago (2016-10-25 06:39:43 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2445233004/diff/1/test/mjsunit/regress/regress-5559.js File test/mjsunit/regress/regress-5559.js (right): https://codereview.chromium.org/2445233004/diff/1/test/mjsunit/regress/regress-5559.js#newcode18 test/mjsunit/regress/regress-5559.js:18: exec_state.prepareStep(Debug.StepAction.StepFrame); StepOut as discussed offline. https://codereview.chromium.org/2445233004/diff/1/test/mjsunit/regress/regress-5559.js#newcode37 test/mjsunit/regress/regress-5559.js:37: assertNull(exception); ...
4 years, 1 month ago (2016-10-25 07:28:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445233004/20001
4 years, 1 month ago (2016-10-25 07:31:40 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 08:00:19 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:11:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/baba15223c3a08f87e69ae5c851bcb215f4048df
Cr-Commit-Position: refs/heads/master@{#40549}

Powered by Google App Engine
This is Rietveld 408576698