Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.cc

Issue 2445233003: Inline constants for logging. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_auth_service.cc
diff --git a/chrome/browser/chromeos/arc/arc_auth_service.cc b/chrome/browser/chromeos/arc/arc_auth_service.cc
index 827972626d7bad8e421952bdd23014bd81b89967..4d90817f28e3273c885e5291640b085a71616061 100644
--- a/chrome/browser/chromeos/arc/arc_auth_service.cc
+++ b/chrome/browser/chromeos/arc/arc_auth_service.cc
@@ -71,11 +71,6 @@ bool g_enable_check_android_management_for_testing = false;
// but present the UI to try again.
constexpr base::TimeDelta kArcSignInTimeout = base::TimeDelta::FromMinutes(5);
-const char kStateNotInitialized[] = "NOT_INITIALIZED";
-const char kStateStopped[] = "STOPPED";
-const char kStateFetchingCode[] = "FETCHING_CODE";
-const char kStateActive[] = "ACTIVE";
-
bool IsAccountManaged(Profile* profile) {
return policy::ProfilePolicyConnectorFactory::GetForBrowserContext(profile)
->IsManaged();
@@ -966,13 +961,13 @@ void ArcAuthService::OnAndroidManagementPassed() {
std::ostream& operator<<(std::ostream& os, const ArcAuthService::State& state) {
switch (state) {
case ArcAuthService::State::NOT_INITIALIZED:
- return os << kStateNotInitialized;
+ return os << "NOT_INITIALIZED";
case ArcAuthService::State::STOPPED:
- return os << kStateStopped;
+ return os << "STOPPED";
case ArcAuthService::State::FETCHING_CODE:
- return os << kStateFetchingCode;
+ return os << "FETCHING_CODE";
case ArcAuthService::State::ACTIVE:
- return os << kStateActive;
+ return os << "ACTIVE";
default:
NOTREACHED();
return os;

Powered by Google App Engine
This is Rietveld 408576698