[Extensions Bindings] Add more utility functions

[Extensions Bindings] Add more utility functions

Add utility functions for safely running JS functions and for retrieving
properties from objects. In addition to trimming down some tests by
taking some of the repetetive calls, this ensures we always use the
non-deprecated versions of these calls (where before sometimes we were
using the incorrect ones).

BUG=653596
Committed: https://crrev.com/1e1f6dcee410a2874d04f2b0188b480983a8bfe2
Cr-Commit-Position: refs/heads/master@{#427467}

[Devlin, 2016-10-25 17:34:47]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 17:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 18:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 18:12:59]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-25 18:57:27]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-10-25 18:57:27]

Hey lazyboy@, jbroman's out for the week I think, but I figure this could be a
good time to add a few more utility functions that will be useful in the
upcoming CLs.

[lazyboy, 2016-10-25 20:09:07]

lgtm

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_bin...
File extensions/renderer/api_binding_test_util.cc (right):

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_bin...
extensions/renderer/api_binding_test_util.cc:22: // throw, |out_error| with the
thrown error.
nit: |out_error| contains the thrown error or sth.

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_bin...
extensions/renderer/api_binding_test_util.cc:147: EXPECT_EQ(expected_error,
error);
EXPECT_TRUE(result.isEmpty())?

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_req...
File extensions/renderer/api_request_handler_unittest.cc (right):

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_req...
extensions/renderer/api_request_handler_unittest.cc:37:
RunFunctionOnGlobal(function, context, argc, argv);
Should we check if the returned result is not IsEmpty()?

[Devlin, 2016-10-25 20:27:42]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 20:28:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-10-25 20:55:52]

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_bin...
File extensions/renderer/api_binding_test_util.cc (right):

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_bin...
extensions/renderer/api_binding_test_util.cc:22: // throw, |out_error| with the
thrown error.
On 2016/10/25 20:09:07, lazyboy wrote:
> nit: |out_error| contains the thrown error or sth.

Whoops!  Done.

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_bin...
extensions/renderer/api_binding_test_util.cc:147: EXPECT_EQ(expected_error,
error);
On 2016/10/25 20:09:07, lazyboy wrote:
> EXPECT_TRUE(result.isEmpty())?

Done.

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_req...
File extensions/renderer/api_request_handler_unittest.cc (right):

https://codereview.chromium.org/2445223003/diff/1/extensions/renderer/api_req...
extensions/renderer/api_request_handler_unittest.cc:37:
RunFunctionOnGlobal(function, context, argc, argv);
On 2016/10/25 20:09:07, lazyboy wrote:
> Should we check if the returned result is not IsEmpty()?

I think this is guaranteed by the ToLocal() conversion in RunFunctionImpl(), but
to be safe, I've added an explicit check in RunFunction().

[Devlin, 2016-10-25 20:55:57]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-10-25 20:55:59]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-10-25 20:55:59]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2445223003/#ps20001
(title: "lazyboy's")

[Devlin, 2016-10-25 20:56:02]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-10-25 20:56:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 21:04:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-25 21:08:02]

Description was changed from

==========
[Extensions Bindings] Add more utility functions

Add utility functions for safely running JS functions and for retrieving
properties from objects. In addition to trimming down some tests by
taking some of the repetetive calls, this ensures we always use the
non-deprecated versions of these calls (where before sometimes we were
using the incorrect ones).

BUG=653596
==========

to

==========
[Extensions Bindings] Add more utility functions

Add utility functions for safely running JS functions and for retrieving
properties from objects. In addition to trimming down some tests by
taking some of the repetetive calls, this ensures we always use the
non-deprecated versions of these calls (where before sometimes we were
using the incorrect ones).

BUG=653596

Committed: https://crrev.com/1e1f6dcee410a2874d04f2b0188b480983a8bfe2
Cr-Commit-Position: refs/heads/master@{#427467}
==========

[commit-bot: I haz the power, 2016-10-25 21:08:03]

Patchset 2 (id:??) landed as
https://crrev.com/1e1f6dcee410a2874d04f2b0188b480983a8bfe2
Cr-Commit-Position: refs/heads/master@{#427467}