[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280, chromium:659111
Committed: https://crrev.com/46a1b34e863aae2d67fc0c69c7bfd3e8b5fc967f
Cr-Commit-Position: refs/heads/master@{#40598}

[mythria, 2016-10-25 16:51:16]

The CQ bit was checked by mythria@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 16:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mythria, 2016-10-25 16:52:48]

Description was changed from

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Decreased the code size
threshold of the functions that can be OSRed.

BUG=v8:4280
==========

to

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280
==========

[commit-bot: I haz the power, 2016-10-25 17:17:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 17:17:49]

Dry run: This issue passed the CQ dry run.

[mythria, 2016-10-26 07:56:00]

Description was changed from

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280
==========

to

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280,chromium:659111
==========

[mythria, 2016-10-26 08:17:14]

mythria@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[mythria, 2016-10-26 08:17:16]

Hi Benedikt and Ross,

This cl is to tune runtime profile metrics to help both ignition-staging and
ignition + turbofan pipelines. 

PTAL.

Thanks,
Mythri

https://codereview.chromium.org/2445203003/diff/20001/src/interpreter/interpr...
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/2445203003/diff/20001/src/interpreter/interpr...
src/interpreter/interpreter.h:70: static const int kCodeSizeMultiplier = 32;
I reset the code size multiplier in interpreter to 32 and instead added a new
parameter in runtime-profiler to tune turbofan and cranshaft independently.

https://codereview.chromium.org/2445203003/diff/20001/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):

https://codereview.chromium.org/2445203003/diff/20001/src/runtime-profiler.cc...
src/runtime-profiler.cc:31: static const int
kProfilerTicksBeforeOptimizingInterpretedFunction = 4;
In my experiments on Octane I found 4 to be a good value, we can tune it further
depending on the results from bots.

https://codereview.chromium.org/2445203003/diff/20001/src/runtime-profiler.cc...
src/runtime-profiler.cc:48: 100 * FullCodeGenerator::kCodeSizeMultiplier;
In my initial patch, I also changed this metric for default pipeline. It seems
to help Octane (+7% overall) but regresses sunspider (-1% overall) on the bots.
I can't reproduce the improvements on octane (Gameboy improves by 50% on the
bots), so I reset it to the default values. I will look into this after I
investigate why Gameboy and Box2d are varying a lot.

https://codereview.chromium.org/2445203003/diff/20001/src/runtime-profiler.cc...
src/runtime-profiler.cc:50: 10 * interpreter::Interpreter::kCodeSizeMultiplier;
This and the change to OSRCodeSizeAllowancePerTIck helps sunspider quite a bit.
Overall 11% improvement. Jetstream improves by 5%. If the bots are to be trusted
we get 1-2% overall improvement on Octane and Kraken. Though locally I don't see
similar improvements on octane.

[Benedikt Meurer, 2016-10-26 08:37:36]

LGTM, thanks.

[rmcilroy, 2016-10-26 14:19:13]

LGTM thanks!

[mythria, 2016-10-26 16:30:56]

The CQ bit was checked by mythria@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:31:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:32:35]

Description was changed from

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280,chromium:659111
==========

to

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280,chromium:659111
==========

[commit-bot: I haz the power, 2016-10-26 16:32:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:14:25]

Description was changed from

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280,chromium:659111
==========

to

==========
[Interpreter] Tune runtime profiler parameters for turbofan and OSR.

Turbofan requires a different tuning when compared to crankshaft. Crankshaft
typically has faster compilation times when compared to turbofan. Hence,
added a new parameter, so that crankshaft and turbofan can be tuned
independently.

OSRing too soon is not good for performance, especially for sunspider
benchmarks. Since they are really small functions and optimizing them is
more expensive than just executing unoptimized code. Tuning the code size
threshold of the functions that can be OSRed from ignition.

BUG=v8:4280,chromium:659111

Committed: https://crrev.com/46a1b34e863aae2d67fc0c69c7bfd3e8b5fc967f
Cr-Commit-Position: refs/heads/master@{#40598}
==========

[commit-bot: I haz the power, 2016-11-17 22:14:26]

Patchset 2 (id:??) landed as
https://crrev.com/46a1b34e863aae2d67fc0c69c7bfd3e8b5fc967f
Cr-Commit-Position: refs/heads/master@{#40598}