Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2445193008: Add unknown dimension for data use histograms (Closed)

Created:
4 years, 1 month ago by Raj
Modified:
4 years, 1 month ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unknown dimension for data use histograms Following CL changed data use histograms to be logged as foreground, background and unknown. This CL adds the dimensions to histograms.xml. https://crrev.com/b07005bcaac418bfed5e0e3a93edb025c8e43dfa BUG=648808 Committed: https://crrev.com/4a5e8956c85b5ac72858d08cd472babc89e9c9b9 Cr-Commit-Position: refs/heads/master@{#428314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Raj
4 years, 1 month ago (2016-10-27 21:08:43 UTC) #2
rkaplow
lgtm
4 years, 1 month ago (2016-10-28 01:13:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445193008/1
4 years, 1 month ago (2016-10-28 06:58:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 07:57:21 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 08:01:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a5e8956c85b5ac72858d08cd472babc89e9c9b9
Cr-Commit-Position: refs/heads/master@{#428314}

Powered by Google App Engine
This is Rietveld 408576698