Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2445193007: Add a couple of regression tests for float fragmentation. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a couple of regression tests for float fragmentation. These tests change the fragmentainer heights, so that the float will fit in the first fragmentainer afterwards, rather than in the second one. Committed: https://crrev.com/1dd04fbb2c39c82fdd772888bfe00d082cc5f50d Cr-Commit-Position: refs/heads/master@{#428160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fragmentation/change-fragmentainer-height-block-float.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fragmentation/change-fragmentainer-height-inline-float.html View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
Not sure if I'm going to be able to let floats use the fragmentation layout ...
4 years, 1 month ago (2016-10-27 21:05:12 UTC) #4
eae
Excellent! LGTM
4 years, 1 month ago (2016-10-27 22:01:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445193007/1
4 years, 1 month ago (2016-10-27 22:07:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 22:15:36 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:19:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dd04fbb2c39c82fdd772888bfe00d082cc5f50d
Cr-Commit-Position: refs/heads/master@{#428160}

Powered by Google App Engine
This is Rietveld 408576698