Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Issue 2445173002: DevTools: Fix highlight/selection of marker events (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix highlight/selection of marker events These one were placed incorrectly because of duration is NaN. drive-by: get rid of highlightTimeRange function. Committed: https://crrev.com/97df95a81783383553dfac5ec6a68b3f704acc65 Cr-Commit-Position: refs/heads/master@{#427260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -40 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 2 chunks +6 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alph
4 years, 1 month ago (2016-10-25 00:07:03 UTC) #2
caseq
lgtm
4 years, 1 month ago (2016-10-25 01:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445173002/1
4 years, 1 month ago (2016-10-25 01:02:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 03:07:55 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 03:10:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97df95a81783383553dfac5ec6a68b3f704acc65
Cr-Commit-Position: refs/heads/master@{#427260}

Powered by Google App Engine
This is Rietveld 408576698