Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_parser.h

Issue 2445153002: Move onc and proxy pref names to components. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_cros_settings_parser.h
diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.h b/chrome/browser/chromeos/proxy_cros_settings_parser.h
index 57848c424c57fb27e7a852ce1cac859548c346f1..183a9f99c25ae013c9cfbe0d2a5ac1982ef7eb9f 100644
--- a/chrome/browser/chromeos/proxy_cros_settings_parser.h
+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.h
@@ -17,6 +17,9 @@ namespace chromeos {
class UIProxyConfigService;
+// This namespace defines helper functions for setting/getting Proxy settings.
emaxx 2016/10/26 01:34:30 nit: The comment should probably be corrected, as
stevenjb 2016/10/26 16:19:31 Done.
+namespace proxy_cros_settings_parser {
+
extern const char kProxyPacUrl[];
extern const char kProxySingleHttp[];
extern const char kProxySingleHttpPort[];
@@ -36,9 +39,6 @@ extern const char kProxyUsePacUrl[];
extern const char* const kProxySettings[];
extern const size_t kProxySettingsCount;
-// This namespace defines helper functions for setting/getting Proxy settings.
-namespace proxy_cros_settings_parser {
-
// Returns true if the supplied |path| is a proxy preference name.
bool IsProxyPref(const std::string& path);

Powered by Google App Engine
This is Rietveld 408576698