Move onc and proxy pref names to components.

chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 15 matching lines @@
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h"
 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/chromeos/proxy_cros_settings_parser.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/chromeos/ui_account_tweaks.h"
 #include "chrome/browser/ui/webui/options/chromeos/accounts_options_handler.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
+#include "components/onc/onc_pref_names.h"
 #include "components/prefs/pref_change_registrar.h"
 #include "components/proxy_config/proxy_config_pref_names.h"
 #include "components/user_manager/user_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_ui.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace chromeos {
 namespace options {
@@ skipping 97 matching lines @@
   proxy_config_service_.SetCurrentNetworkGuid("");
   // And clear the cached configuration.
   proxy_config_service_.UpdateFromPrefs();
 
   CoreOptionsHandler::InitializeHandler();
 
   PrefService* profile_prefs = NULL;
   Profile* profile = Profile::FromWebUI(web_ui());
   if (!ProfileHelper::IsSigninProfile(profile)) {
     profile_prefs = profile->GetPrefs();
-    ObservePref(prefs::kOpenNetworkConfiguration);
+    ObservePref(onc::prefs::kOpenNetworkConfiguration);
   }
   ObservePref(proxy_config::prefs::kProxy);
-  ObservePref(prefs::kDeviceOpenNetworkConfiguration);
+  ObservePref(onc::prefs::kDeviceOpenNetworkConfiguration);
   proxy_config_service_.SetPrefs(profile_prefs,
                                  g_browser_process->local_state());
 }
 
 void CoreChromeOSOptionsHandler::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK_EQ(chrome::NOTIFICATION_OWNERSHIP_STATUS_CHANGED, type);
 
@@ skipping 13 matching lines @@
     const std::string& pref_name) {
   if (proxy_cros_settings_parser::IsProxyPref(pref_name)) {
     base::Value* value = nullptr;
     proxy_cros_settings_parser::GetProxyPrefValue(
         proxy_config_service_, pref_name, &value);
     return value ? value : base::Value::CreateNullValue().release();
   }
 
   Profile* profile = Profile::FromWebUI(web_ui());
   if (!CrosSettings::IsCrosSettings(pref_name)) {
-    std::string controlling_pref = pref_name == prefs::kUseSharedProxies
-                                       ? proxy_config::prefs::kProxy
-                                       : std::string();
+    std::string controlling_pref =
+        pref_name == proxy_config::prefs::kUseSharedProxies
+            ? proxy_config::prefs::kProxy
+            : std::string();
     base::Value* value = CreateValueForPref(pref_name, controlling_pref);
     if (!IsSettingShared(pref_name) || !IsSecondaryUser(profile))
       return value;
     base::DictionaryValue* dict;
     if (!value->GetAsDictionary(&dict) || dict->HasKey("controlledBy"))
       return value;
     Profile* primary_profile = ProfileHelper::Get()->GetProfileByUser(
         user_manager::UserManager::Get()->GetPrimaryUser());
     if (!primary_profile)
       return value;
@@ skipping 180 matching lines @@
   }
   proxy_config_service_.SetCurrentNetworkGuid(guid);
   NotifyProxyPrefsChanged();
 }
 
 void CoreChromeOSOptionsHandler::OnPreferenceChanged(
     PrefService* service,
     const std::string& pref_name) {
   // Redetermine the current proxy settings and notify the UI if any of these
   // preferences change.
-  if (pref_name == prefs::kOpenNetworkConfiguration ||
-      pref_name == prefs::kDeviceOpenNetworkConfiguration ||
+  if (pref_name == onc::prefs::kOpenNetworkConfiguration ||
+      pref_name == onc::prefs::kDeviceOpenNetworkConfiguration ||
       pref_name == proxy_config::prefs::kProxy) {
     NotifyProxyPrefsChanged();
     return;
   }
-  if (pref_name == prefs::kUseSharedProxies) {
+  if (pref_name == proxy_config::prefs::kUseSharedProxies) {
     // kProxy controls kUseSharedProxies and decides if it's managed by
     // policy/extension.
-    NotifyPrefChanged(prefs::kUseSharedProxies, proxy_config::prefs::kProxy);
+    NotifyPrefChanged(proxy_config::prefs::kUseSharedProxies,
+                      proxy_config::prefs::kProxy);
     return;
   }
   ::options::CoreOptionsHandler::OnPreferenceChanged(service, pref_name);
 }
 
 void CoreChromeOSOptionsHandler::NotifySettingsChanged(
     const std::string& setting_name) {
   DCHECK(CrosSettings::Get()->IsCrosSettings(setting_name));
   std::unique_ptr<base::Value> value(FetchPref(setting_name));
   if (!value.get())
     NOTREACHED();
   DispatchPrefChangeNotification(setting_name, std::move(value));
 }
 
 void CoreChromeOSOptionsHandler::NotifyProxyPrefsChanged() {
   proxy_config_service_.UpdateFromPrefs();
-  for (size_t i = 0; i < kProxySettingsCount; ++i) {
+  for (size_t i = 0; i < proxy_cros_settings_parser::kProxySettingsCount; ++i) {
     base::Value* value = NULL;
     proxy_cros_settings_parser::GetProxyPrefValue(
-        proxy_config_service_, kProxySettings[i], &value);
+        proxy_config_service_, proxy_cros_settings_parser::kProxySettings[i],
+        &value);
     DCHECK(value);
     std::unique_ptr<base::Value> ptr(value);
-    DispatchPrefChangeNotification(kProxySettings[i], std::move(ptr));
+    DispatchPrefChangeNotification(
+        proxy_cros_settings_parser::kProxySettings[i], std::move(ptr));
   }
 }
 
 }  // namespace options
 }  // namespace chromeos