Move onc and proxy pref names to components.

Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

This CL also namespaces some pseudo-prefs in proxy_cros_settings_parser.cc which were in the global 'chromeos' namespace before, which was super confusing because they aren't actually stored in the pref store, just set to look like prefs for the (soon to be deprecated) options UI code.

BUG=658015
Committed: https://crrev.com/f22f82eaa63e369a1cee77b3473d978fd5de288f
Cr-Commit-Position: refs/heads/master@{#427824}

[stevenjb, 2016-10-24 23:02:03]

stevenjb@chromium.org changed reviewers:
+ battre@chromium.org, mnissler@chromium.org

[stevenjb, 2016-10-24 23:02:03]

mnissler@ - Can you take a look? I'm not sure there's anyone still around who
really understands the proxy prefs. This CL is relatively straightforward
movement of code from src/chrome to components.

battre@ for prefs OWNERS

[stevenjb, 2016-10-24 23:03:45]

Description was changed from

==========
Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

BUG=658015
==========

to

==========
Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

This CL also namespaces some pseudo-prefs in proxy_cros_settings_parser.cc which
were in the global 'chromeos' namespace before, which was super confusing
because they aren't actually stored in the pref store, just set to look like
prefs for the (soon to be deprecated) options UI code.

BUG=658015
==========

[stevenjb, 2016-10-24 23:32:45]

The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 23:33:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[battre, 2016-10-25 07:15:00]

lgtm

[Mattias Nissler (ping if slow), 2016-10-25 09:35:51]

Looks reasonable to me, as long as the goal is to re-unite the prefs with the
code handling them in the respective components.

Anyhow, I no longer got any powers in Chrome land :)

[stevenjb, 2016-10-26 00:18:48]

stevenjb@chromium.org changed reviewers:
+ emaxx@chromium.org

[stevenjb, 2016-10-26 00:18:48]

+emaxx@, can you review this? It's just some re-factoring, there shouldn't be
any functional changes. Thanks!

[emaxx, 2016-10-26 01:34:30]

lgtm

https://codereview.chromium.org/2445153002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/proxy_cros_settings_parser.h (right):

https://codereview.chromium.org/2445153002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/proxy_cros_settings_parser.h:20: // This namespace
defines helper functions for setting/getting Proxy settings.
nit: The comment should probably be corrected, as the namespace now contains
some constants too.

https://codereview.chromium.org/2445153002/diff/40001/components/onc/onc_pref...
File components/onc/onc_pref_names.cc (right):

https://codereview.chromium.org/2445153002/diff/40001/components/onc/onc_pref...
components/onc/onc_pref_names.cc:30:
registry->RegisterListPref(::onc::prefs::kDeviceOpenNetworkConfiguration);
nit: Not sure whether you used the full scope here intentionally, but the
"::onc::" part could be omitted.

https://codereview.chromium.org/2445153002/diff/40001/components/onc/onc_pref...
components/onc/onc_pref_names.cc:37: }  // namespace autofill
nit: s/autofill/onc/

[stevenjb, 2016-10-26 16:19:32]

https://codereview.chromium.org/2445153002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/proxy_cros_settings_parser.h (right):

https://codereview.chromium.org/2445153002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/proxy_cros_settings_parser.h:20: // This namespace
defines helper functions for setting/getting Proxy settings.
On 2016/10/26 01:34:30, emaxx wrote:
> nit: The comment should probably be corrected, as the namespace now contains
> some constants too.

Done.

https://codereview.chromium.org/2445153002/diff/40001/components/onc/onc_pref...
File components/onc/onc_pref_names.cc (right):

https://codereview.chromium.org/2445153002/diff/40001/components/onc/onc_pref...
components/onc/onc_pref_names.cc:30:
registry->RegisterListPref(::onc::prefs::kDeviceOpenNetworkConfiguration);
On 2016/10/26 01:34:30, emaxx wrote:
> nit: Not sure whether you used the full scope here intentionally, but the
> "::onc::" part could be omitted.

Done.

https://codereview.chromium.org/2445153002/diff/40001/components/onc/onc_pref...
components/onc/onc_pref_names.cc:37: }  // namespace autofill
On 2016/10/26 01:34:30, emaxx wrote:
> nit: s/autofill/onc/

Done.

[stevenjb, 2016-10-26 16:19:37]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-10-26 16:19:37]

The patchset sent to the CQ was uploaded after l-g-t-m from battre@chromium.org,
emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2445153002/#ps60001
(title: "Feedback")

[commit-bot: I haz the power, 2016-10-26 16:20:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 16:57:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 16:57:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2016-10-26 17:49:30]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2016-10-26 17:49:30]

The patchset sent to the CQ was uploaded after l-g-t-m from battre@chromium.org,
emaxx@chromium.org
Link to the patchset: https://codereview.chromium.org/2445153002/#ps80001
(title: "ONC_EXPORT")

[commit-bot: I haz the power, 2016-10-26 17:50:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:48:05]

Description was changed from

==========
Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

This CL also namespaces some pseudo-prefs in proxy_cros_settings_parser.cc which
were in the global 'chromeos' namespace before, which was super confusing
because they aren't actually stored in the pref store, just set to look like
prefs for the (soon to be deprecated) options UI code.

BUG=658015
==========

to

==========
Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

This CL also namespaces some pseudo-prefs in proxy_cros_settings_parser.cc which
were in the global 'chromeos' namespace before, which was super confusing
because they aren't actually stored in the pref store, just set to look like
prefs for the (soon to be deprecated) options UI code.

BUG=658015
==========

[commit-bot: I haz the power, 2016-10-26 21:48:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-26 21:51:12]

Description was changed from

==========
Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

This CL also namespaces some pseudo-prefs in proxy_cros_settings_parser.cc which
were in the global 'chromeos' namespace before, which was super confusing
because they aren't actually stored in the pref store, just set to look like
prefs for the (soon to be deprecated) options UI code.

BUG=658015
==========

to

==========
Move onc and proxy pref names to components.

This is some code cleanup in anticipation of moving chromeos
proxy configuration related code out of src/chrome so that
it can be accessed by networkingPrivate and ash.

This CL also namespaces some pseudo-prefs in proxy_cros_settings_parser.cc which
were in the global 'chromeos' namespace before, which was super confusing
because they aren't actually stored in the pref store, just set to look like
prefs for the (soon to be deprecated) options UI code.

BUG=658015

Committed: https://crrev.com/f22f82eaa63e369a1cee77b3473d978fd5de288f
Cr-Commit-Position: refs/heads/master@{#427824}
==========

[commit-bot: I haz the power, 2016-10-26 21:51:13]

Patchset 5 (id:??) landed as
https://crrev.com/f22f82eaa63e369a1cee77b3473d978fd5de288f
Cr-Commit-Position: refs/heads/master@{#427824}