Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

Issue 2445123002: Make blink settings/features case-sensitive (Closed)
Patch Set: case-sensitive Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl
index 8bdd58c2b5aa567a997b9cbead54cb3010f3506e..4ddb42c6c8cd12c9e6527200db055d5a5b372dda 100644
--- a/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl
@@ -45,12 +45,12 @@ void Settings::set{{setting.name|upper_first}}({{setting.type|to_passing_type}}
void Settings::setFromStrings(const String& name, const String& value) \
{ \
{% for setting in settings %}
- if (equalIgnoringCase(name, "{{setting.name}}")) { \
+ if (name == "{{setting.name}}") { \
set{{setting.name|upper_first}}( \
{% if setting.type == 'String' %}
value \
{% elif setting.type == 'bool' %}
- value.isEmpty() || equalIgnoringCase(value, "true") \
+ value.isEmpty() || value == "true" \
{% elif setting.type == 'int' %}
value.toInt() \
{% elif setting.type == 'float' %}
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/RuntimeEnabledFeatures.cpp.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698