Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Unified Diff: net/spdy/spdy_session.cc

Issue 2445113002: Add HTTP/2 error code NO_ERROR. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 616685d41f47d83e6db0c7e50858c6ef245fcd96..501679b1db88f4b74269cba290280a21a4ca862a 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -413,6 +413,8 @@ SpdyProtocolErrorDetails MapRstStreamStatusToProtocolError(
return STATUS_CODE_INADEQUATE_SECURITY;
case RST_STREAM_HTTP_1_1_REQUIRED:
return STATUS_CODE_HTTP_1_1_REQUIRED;
+ case RST_STREAM_NO_ERROR:
+ return STATUS_CODE_NO_ERROR;
default:
NOTREACHED();
return static_cast<SpdyProtocolErrorDetails>(-1);
@@ -2327,8 +2329,8 @@ void SpdySession::OnRstStream(SpdyStreamId stream_id,
CHECK_EQ(it->second.stream->stream_id(), stream_id);
- if (status == 0) {
- it->second.stream->OnDataReceived(std::unique_ptr<SpdyBuffer>());
+ if (status == RST_STREAM_NO_ERROR) {
xunjieli 2016/10/25 17:12:49 The new code got rid of handling of status == 0 (R
Bence 2016/10/25 22:11:24 I changed the value of RST_STREAM_NO_ERROR to 0, s
+ CloseActiveStreamIterator(it, ERR_SPDY_RST_STREAM_NO_ERROR_RECEIVED);
} else if (status == RST_STREAM_REFUSED_STREAM) {
CloseActiveStreamIterator(it, ERR_SPDY_SERVER_REFUSED_STREAM);
} else if (status == RST_STREAM_HTTP_1_1_REQUIRED) {

Powered by Google App Engine
This is Rietveld 408576698