Client Hints

chrome/browser/net/client_hints_unittest.cc

Index: chrome/browser/net/client_hints_unittest.cc
diff --git a/chrome/browser/net/client_hints_unittest.cc b/chrome/browser/net/client_hints_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c93b3b66d50597303c6e400758d25d4bada777d3
--- /dev/null
+++ b/chrome/browser/net/client_hints_unittest.cc
@@ -0,0 +1,49 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/client_hints.h"
+
+#include <locale.h>
+
+#include "base/logging.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ClientHintsTest : public testing::Test {
+ public:
+  void UpdateScreenInfo(float pixel_ratio) {
+    client_hints_.UpdateScreenInfo(pixel_ratio);
+  };
+
+ protected:
+  ClientHints client_hints_;
+};
+
+TEST_F(ClientHintsTest, HintsWellFormatted) {
+  UpdateScreenInfo(1.567f);
+  std::string hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsWellFormattedWithNonEnLocale) {
+  setlocale(LC_ALL, "fr_FR.UTF-8");

[Avi (use Gerrit), 2013/09/26 19:21:26]

Nooooo. Please don't set a locale and fail to reset it. It wrecks all following
tests!

+  UpdateScreenInfo(1.567f);
+  std::string hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsHaveNonbogusValues) {
+  UpdateScreenInfo(-1.567f);
+  std::string hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("", hint);
+
+  UpdateScreenInfo(1.567f);
+  hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("1.57", hint);
+
+  UpdateScreenInfo(0.0f);
+  hint = client_hints_.GetDevicePixelRatioHeader();
+  // Hints should be last known good values.
+  EXPECT_EQ("1.57", hint);
+}
+