Client Hints

chrome/browser/net/client_hints_unittest.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/net/client_hints.h"
+
+#include <locale.h>
+
+#include "base/logging.h"
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+#include "base/test/scoped_locale.h"
+#endif
+#include "testing/gtest/include/gtest/gtest.h"
+
+class ClientHintsTest : public testing::Test {
+ public:
+  void UpdateScreenInfo(float pixel_ratio) {
+    client_hints_.UpdateScreenInfo(pixel_ratio);
+  };
+
+ protected:
+  ClientHints client_hints_;
+};
+
+TEST_F(ClientHintsTest, HintsWellFormatted) {
+  UpdateScreenInfo(1.567f);
+  std::string hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsWellFormattedWithNonEnLocale) {
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+  // Android and iOS do not support setLocal.

[Avi (use Gerrit), 2013/09/30 17:35:55]

Without ScopedLocale, this test is meaningless (and is already covered by
HintsWellFormatted above). You should comment out the whole test rather than
just the ScopedLocale.

[bengr, 2013/09/30 17:42:23]

Done.

+  base::ScopedLocale locale("fr_FR.UTF-8");
+#endif
+  UpdateScreenInfo(1.567f);
+  std::string hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("1.57", hint);
+}
+
+TEST_F(ClientHintsTest, HintsHaveNonbogusValues) {
+  UpdateScreenInfo(-1.567f);
+  std::string hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("", hint);
+
+  UpdateScreenInfo(1.567f);
+  hint = client_hints_.GetDevicePixelRatioHeader();
+  EXPECT_EQ("1.57", hint);
+
+  UpdateScreenInfo(0.0f);
+  hint = client_hints_.GetDevicePixelRatioHeader();
+  // Hints should be last known good values.
+  EXPECT_EQ("1.57", hint);
+}
+