Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2811)

Unified Diff: cc/trees/layer_tree_host_in_process.h

Issue 2445093002: cc/blimp: Add synchronization for scroll/scale state. (Closed)
Patch Set: missed a comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_in_process.h
diff --git a/cc/trees/layer_tree_host_in_process.h b/cc/trees/layer_tree_host_in_process.h
index 805fb5913d411570ae0e3b6bff074234b92de12f..21adc50bba33805941bd5fd2cf523851192abde1 100644
--- a/cc/trees/layer_tree_host_in_process.h
+++ b/cc/trees/layer_tree_host_in_process.h
@@ -73,6 +73,7 @@ class SharedBitmapManager;
class TaskGraphRunner;
class TopControlsManager;
struct PendingPageScaleAnimation;
+struct ReflectedMainFrameState;
struct RenderingStats;
struct ScrollAndScaleSet;
@@ -196,6 +197,9 @@ class CC_EXPORT LayerTreeHostInProcess : public LayerTreeHost {
void DidCompletePageScaleAnimation();
void ApplyScrollAndScale(ScrollAndScaleSet* info);
+ void SetReflectedMainFrameState(
+ std::unique_ptr<ReflectedMainFrameState> reflected_main_frame_state);
+
LayerTreeHostClient* client() { return client_; }
bool gpu_rasterization_histogram_recorded() const {
@@ -367,6 +371,15 @@ class CC_EXPORT LayerTreeHostInProcess : public LayerTreeHost {
SurfaceSequenceGenerator surface_sequence_generator_;
uint32_t num_consecutive_frames_suitable_for_gpu_ = 0;
+ // The state that was expected to be reflected from the main thread during
+ // BeginMainFrame, but could not be done. The client provides these deltas
+ // to use during the commit instead of applying them at that point because
+ // its necessary for these deltas to be applied *after* PropertyTrees are
+ // built/updated on the main thread.
+ // TODO(khushalsagar): Investigate removing this after SPV2, since then we
+ // should get these PropertyTrees directly from blink?
+ std::unique_ptr<ReflectedMainFrameState> reflected_main_frame_state_;
+
DISALLOW_COPY_AND_ASSIGN(LayerTreeHostInProcess);
};

Powered by Google App Engine
This is Rietveld 408576698