Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Unified Diff: cc/test/layer_tree_host_remote_for_testing.h

Issue 2445093002: cc/blimp: Add synchronization for scroll/scale state. (Closed)
Patch Set: missed a comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/layer_tree_host_remote_for_testing.h
diff --git a/cc/test/layer_tree_host_remote_for_testing.h b/cc/test/layer_tree_host_remote_for_testing.h
index 2af67222c216ce9103ace73e0dd51907661702ee..71a93c2b179c673bdb48fd18cc7e5a0003a91407 100644
--- a/cc/test/layer_tree_host_remote_for_testing.h
+++ b/cc/test/layer_tree_host_remote_for_testing.h
@@ -6,7 +6,7 @@
#define CC_TEST_LAYER_TREE_HOST_REMOTE_FOR_TESTING_H_
#include "base/macros.h"
-#include "cc/blimp/compositor_state_deserializer_client.h"
+#include "cc/blimp/compositor_state_deserializer.h"
#include "cc/blimp/layer_tree_host_remote.h"
#include "ui/gfx/geometry/scroll_offset.h"
kuzminruslan 2016/10/30 13:18:41 Perhaps not needed header
Khushal 2016/10/31 23:00:27 Done.
@@ -15,7 +15,6 @@ class GpuMemoryBufferManager;
} // namespace gpu
namespace cc {
-class CompositorStateDeserializer;
class FakeImageSerializationProcessor;
class LayerTreeHostInProcess;
class SharedBitmapManager;
@@ -81,15 +80,12 @@ class LayerTreeHostRemoteForTesting : public LayerTreeHostRemote,
class RemoteCompositorBridgeImpl;
// CompositorStateDeserializerClient implementation.
- bool ShouldRetainClientScroll(int engine_layer_id,
- const gfx::ScrollOffset& new_offset) override;
- bool ShouldRetainClientPageScale(float new_page_scale) override;
+ void DidUpdateLocalState() override;
// LayerTreeHostRemote interface.
void DispatchDrawAndSubmitCallbacks() override;
- void LayerDidScroll(int engine_layer_id);
- void ApplyUpdatesFromInProcessHost();
+ void BeginRemoteMainFrame();
void RemoteHostNeedsMainFrame();
void ProcessRemoteCompositorUpdate(
@@ -98,7 +94,7 @@ class LayerTreeHostRemoteForTesting : public LayerTreeHostRemote,
std::unique_ptr<LayerTreeHostInProcess> layer_tree_host_in_process_;
std::unique_ptr<CompositorStateDeserializer> compositor_state_deserializer_;
- ScrollOffsetMap layers_scrolled_;
+ bool client_state_dirty_ = false;
std::unique_ptr<LayerTreeHostInProcessClient>
layer_tree_host_in_process_client_;

Powered by Google App Engine
This is Rietveld 408576698