cc/blimp: Add synchronization for scroll/scale state.

cc/trees/layer_tree.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree.h"
 
 #include "base/auto_reset.h"
 #include "base/time/time.h"
 #include "cc/animation/animation_host.h"
 #include "cc/input/page_scale_animation.h"
@@ skipping 325 matching lines @@
 
 const LayerTreeSettings& LayerTree::GetSettings() const {
   return layer_tree_host_->GetSettings();
 }
 
 void LayerTree::SetPropertyTreesNeedRebuild() {
   property_trees_.needs_rebuild = true;
   layer_tree_host_->SetNeedsUpdateLayers();
 }
 
-void LayerTree::PushPropertiesTo(LayerTreeImpl* tree_impl) {
+void LayerTree::PushPropertiesTo(LayerTreeImpl* tree_impl,
+                                 float unapplied_page_scale_delta) {
   tree_impl->set_needs_full_tree_sync(needs_full_tree_sync_);
   needs_full_tree_sync_ = false;
 
   if (hud_layer_.get()) {
     LayerImpl* hud_impl = tree_impl->LayerById(hud_layer_->id());
     tree_impl->set_hud_layer(static_cast<HeadsUpDisplayLayerImpl*>(hud_impl));
   } else {
     tree_impl->set_hud_layer(nullptr);
   }
 
@@ skipping 36 matching lines @@
   if (inputs_.root_layer && property_trees_changed_on_active_tree) {
     if (property_trees_.sequence_number ==
         tree_impl->property_trees()->sequence_number)
       tree_impl->property_trees()->PushChangeTrackingTo(&property_trees_);
     else
       tree_impl->MoveChangeTrackingToLayers();
   }
   // Setting property trees must happen before pushing the page scale.
   tree_impl->SetPropertyTrees(&property_trees_);
 
-  tree_impl->PushPageScaleFromMainThread(inputs_.page_scale_factor,
-                                         inputs_.min_page_scale_factor,
-                                         inputs_.max_page_scale_factor);
+  tree_impl->PushPageScaleFromMainThread(
+      inputs_.page_scale_factor * unapplied_page_scale_delta,

[aelias_OOO_until_Jul13, 2016/10/28 03:40:20]

Hmm, this resembles the approach I suggested for scrolling which you argued is
incorrect because it ends up applying to the transform, isn't that also the case
here?

[Khushal, 2016/10/31 21:02:01]

I did a little bit more digging, and finally landed onto exactly what's
different. Its basically how the layer tree hierarchy is mapped to property
trees and the way this is handled differently on the main thread,
https://cs.chromium.org/chromium/src/cc/trees/property_tree.h?l=208

From what I understand, in PropertyTrees, the |source_node_id| is not the same
as the transform parent id for fixed position layers. The source to parent
offset is set when updating the property tree transforms on the main thread side
to account for the layer's position, but this is disabled on the compositor
thread since no compositor thread effects would change this.

This change is working with this by updating the offsets with the deltas on the
compositor thread side property trees, which is necessary because for the scroll
offsets blink has seen, it will re-position the layers to account for them, but
the additional delta accumulated on the client main thread now has to be applied
the same way deltas are applied on the compositor thread. I guess with Spv2 if
blink is generating property trees, they should set the same hierarchy and
update them the same way for fixed position elements, the way cc does?
+ajuma since he has a lot more context on this too.

+      inputs_.min_page_scale_factor, inputs_.max_page_scale_factor);
 
   tree_impl->set_top_controls_shrink_blink_size(
       inputs_.top_controls_shrink_blink_size);
   tree_impl->set_top_controls_height(inputs_.top_controls_height);
   tree_impl->set_bottom_controls_height(inputs_.bottom_controls_height);
   tree_impl->PushTopControlsFromMainThread(inputs_.top_controls_shown_ratio);
   tree_impl->elastic_overscroll()->PushFromMainThread(elastic_overscroll_);
   if (tree_impl->IsActiveTree())
     tree_impl->elastic_overscroll()->PushPendingToActive();
 
@@ skipping 275 matching lines @@
 LayerListReverseIterator<Layer> LayerTree::rend() {
   return LayerListReverseIterator<Layer>(nullptr);
 }
 
 void LayerTree::SetNeedsDisplayOnAllLayers() {
   for (auto* layer : *this)
     layer->SetNeedsDisplay();
 }
 
 }  // namespace cc