Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2445083002: Fixed bad WebVR content judder when the HTTP warning was displayed (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
klausw, bshe, cjgrant
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed bad WebVR content judder when the HTTP warning was displayed BUG=389343 Committed: https://crrev.com/c157a5ad42329f513f124d7d609d086d33310e84 Cr-Commit-Position: refs/heads/master@{#427276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/android/vr_shell/vr_shell.cc View 2 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
bajones
The previous jitter fix cause the frame identifier to be read from the wrong buffer. ...
4 years, 1 month ago (2016-10-24 19:46:01 UTC) #2
cjgrant
On 2016/10/24 19:46:01, bajones wrote: > The previous jitter fix cause the frame identifier to ...
4 years, 1 month ago (2016-10-24 19:58:38 UTC) #3
klausw
lgtm
4 years, 1 month ago (2016-10-24 20:03:14 UTC) #4
bshe
On 2016/10/24 20:03:14, klausw wrote: > lgtm lgtm
4 years, 1 month ago (2016-10-24 20:50:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445083002/1
4 years, 1 month ago (2016-10-24 21:05:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/151183)
4 years, 1 month ago (2016-10-25 00:36:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445083002/1
4 years, 1 month ago (2016-10-25 04:26:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 04:51:57 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 04:53:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c157a5ad42329f513f124d7d609d086d33310e84
Cr-Commit-Position: refs/heads/master@{#427276}

Powered by Google App Engine
This is Rietveld 408576698