Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2445053002: Fix history nav to a script-injected about:blank frame. (Closed)

Created:
4 years, 1 month ago by Charlie Reis
Modified:
4 years, 1 month ago
Reviewers:
alexmos
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fix history nav to a script-injected about:blank frame. This CL tracks whether the browser process has an about:blank history item for subframes during a history navigation. If the renderer would be staying on about:blank, it can skip asking the browser and commit the initial about:blank page synchronously. BUG=657896, 639842 TEST=See bug for repro steps. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation R=alexmos@chromium.org Review URL: https://codereview.chromium.org/2438743005 . Cr-Commit-Position: refs/heads/master@{#426880} (cherry picked from commit 37c954965f2f221aec294a0a28dfbba1c7543f2a) Committed: https://chromium.googlesource.com/chromium/src/+/411325b228248f37b4977f304550d42f0ce04638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -92 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 3 chunks +256 lines, -16 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +12 lines, -9 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 2 chunks +25 lines, -5 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/navigation_params.h View 3 chunks +9 lines, -8 lines 0 comments Download
M content/common/navigation_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +11 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +39 lines, -45 lines 0 comments Download
A content/test/data/navigation_controller/inject_iframe_srcdoc_with_nested_frame.html View 1 chunk +14 lines, -0 lines 0 comments Download
A content/test/data/navigation_controller/inject_subframe_into_blank_iframe.html View 1 chunk +20 lines, -0 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Charlie Reis
4 years, 1 month ago (2016-10-24 18:27:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
411325b228248f37b4977f304550d42f0ce04638.

Powered by Google App Engine
This is Rietveld 408576698