Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2445033002: Remove CFI blacklists entries for the fixed bug. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
haraken, pcc1
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CFI blacklists entries for the fixed bug. BUG=568891 Committed: https://crrev.com/08f73f5e954340b0c0b5e29f75568ffdebb80588 Cr-Commit-Position: refs/heads/master@{#427126}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M tools/cfi/blacklist.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
krasin1
4 years, 1 month ago (2016-10-24 17:59:01 UTC) #3
pcc1
LGTM
4 years, 1 month ago (2016-10-24 18:00:20 UTC) #5
haraken
Thanks, LGTM
4 years, 1 month ago (2016-10-24 18:00:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2445033002/1
4 years, 1 month ago (2016-10-24 19:34:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 19:49:29 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08f73f5e954340b0c0b5e29f75568ffdebb80588 Cr-Commit-Position: refs/heads/master@{#427126}
4 years, 1 month ago (2016-10-24 19:56:04 UTC) #13
krasin1
4 years, 1 month ago (2016-10-24 22:14:07 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2446803004/ by krasin@chromium.org.

The reason for reverting is: Broke 'CFI Linux Full' bot:
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20Full/builds/....

Powered by Google App Engine
This is Rietveld 408576698