Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 2444973002: Specify the rect invalidated by SetLayerTransform. (Closed)

Created:
4 years, 1 month ago by Kevin McNee - google account
Modified:
4 years, 1 month ago
Reviewers:
bokan, wjmaclean, raymes, wjmaclean, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify the rect invalidated by SetLayerTransform. When SetLayerTransform was introduced, instead of specifying the rect that is invalidated, the no_update_visible flag was manually set to false to indicate that the flush callback needs to be executed. Since nothing was invalidated, we don't get calls to ViewInitiatedPaint, which delays the callback. By setting the op_rect like the other queued commands do, the invalidations and callback scheduling are done correctly. BUG=605379 Committed: https://crrev.com/9fb5007ba0a99358e8418f0c2b3791705006a7c0 Cr-Commit-Position: refs/heads/master@{#427459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/renderer/pepper/pepper_graphics_2d_host.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Kevin McNee - google account
raymes: Hello. Could you take a look at this change? There was a problem with ...
4 years, 1 month ago (2016-10-24 15:51:06 UTC) #3
wjmaclean_google.com
On 2016/10/24 15:51:06, Kevin McNee wrote: > raymes: Hello. Could you take a look at ...
4 years, 1 month ago (2016-10-24 16:44:22 UTC) #4
bokan
seems reasonable to me, non-OWNER lgtm
4 years, 1 month ago (2016-10-24 17:03:28 UTC) #5
raymes
I defer to piman who originally reviewed this change.
4 years, 1 month ago (2016-10-25 03:08:43 UTC) #7
piman
lgtm
4 years, 1 month ago (2016-10-25 19:14:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444973002/1
4 years, 1 month ago (2016-10-25 19:49:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 20:49:51 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 20:51:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9fb5007ba0a99358e8418f0c2b3791705006a7c0
Cr-Commit-Position: refs/heads/master@{#427459}

Powered by Google App Engine
This is Rietveld 408576698