Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackCue.h
diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h
index fc9f9407e9430a93959f29ac38190513e9f3511a..db12b4789c9ccaf7e4543d58a3f97e080832ee57 100644
--- a/Source/core/html/track/TextTrackCue.h
+++ b/Source/core/html/track/TextTrackCue.h
@@ -34,14 +34,15 @@
#include "core/events/EventTarget.h"
#include "core/html/HTMLDivElement.h"
+#include "platform/heap/Handle.h"
#include "wtf/RefCounted.h"
namespace WebCore {
class ExceptionState;
-class TextTrackCue : public RefCounted<TextTrackCue>, public EventTargetWithInlineData {
- REFCOUNTED_EVENT_TARGET(TextTrackCue);
+class TextTrackCue : public RefCountedWillBeRefCountedGarbageCollected<TextTrackCue>, public EventTargetWithInlineData {
+ DEFINE_EVENT_TARGET_REFCOUNTING(RefCountedWillBeRefCountedGarbageCollected<TextTrackCue>);
public:
static bool isInfiniteOrNonNumber(double value, ExceptionState&);
@@ -94,6 +95,8 @@ public:
DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
+ virtual void trace(Visitor*);
+
protected:
TextTrackCue(double start, double end);
@@ -106,7 +109,7 @@ private:
double m_endTime;
int m_cueIndex;
- TextTrack* m_track;
+ RawPtrWillBeMember<TextTrack> m_track;
bool m_isActive : 1;
bool m_pauseOnExit : 1;

Powered by Google App Engine
This is Rietveld 408576698