Source/bindings/v8/Dictionary.cpp - Issue 244493002: Oilpan: add transition types to track interface objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Explicitly dispose of TextTrackList + fix handling of {Inband,Loadable}TextTrack Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/Dictionary.cpp

diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp

index a5d377af12724b5637c76e99426e42b5a07538d7..87d0dfd05942930a0c36fce5be5deb9c351c091f 100644

--- a/Source/bindings/v8/Dictionary.cpp

+++ b/Source/bindings/v8/Dictionary.cpp

@@ -460,7 +460,7 @@ bool Dictionary::get(const String& key, RefPtr<MediaKeyError>& value) const

return true;

}

-bool Dictionary::get(const String& key, RefPtr<TrackBase>& value) const

+bool Dictionary::get(const String& key, RefPtrWillBeMember<TrackBase>& value) const

{

v8::Local<v8::Value> v8Value;

if (!getKey(key, v8Value))

« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | Source/core/html/HTMLMediaElement.h » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')