Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: Source/core/html/track/vtt/VTTCue.h

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add crbug.com/365260 crashing test + expectation Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/TrackEvent.h ('k') | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.h
diff --git a/Source/core/html/track/vtt/VTTCue.h b/Source/core/html/track/vtt/VTTCue.h
index 2247f019f4ec84396f6ba613e4d34dde8b85a7f7..f69b0bdb9d8def0e8b6283a9e9d69852160b3f93 100644
--- a/Source/core/html/track/vtt/VTTCue.h
+++ b/Source/core/html/track/vtt/VTTCue.h
@@ -32,6 +32,7 @@
#include "bindings/v8/ScriptWrappable.h"
#include "core/html/track/TextTrackCue.h"
+#include "platform/heap/Handle.h"
namespace WebCore {
@@ -55,14 +56,17 @@ private:
virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;
+ // FIXME: Oilpan: once Node has been moved onto the heap fully,
+ // drop the raw pointer for a Member (and vice versa from
+ // VTTCue.)
VTTCue* m_cue;
};
class VTTCue FINAL : public TextTrackCue, public ScriptWrappable {
public:
- static PassRefPtr<VTTCue> create(Document& document, double startTime, double endTime, const String& text)
+ static PassRefPtrWillBeRawPtr<VTTCue> create(Document& document, double startTime, double endTime, const String& text)
{
- return adoptRef(new VTTCue(document, startTime, endTime, text));
+ return adoptRefWillBeRefCountedGarbageCollected(new VTTCue(document, startTime, endTime, text));
}
virtual ~VTTCue();
@@ -137,6 +141,8 @@ public:
virtual String toString() const OVERRIDE;
#endif
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
VTTCue(Document&, double startTime, double endTime, const String& text);
« no previous file with comments | « Source/core/html/track/TrackEvent.h ('k') | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698