Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Unified Diff: Source/core/html/HTMLTrackElement.cpp

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add missing tracing to HTMLTrackElement. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLTrackElement.cpp
diff --git a/Source/core/html/HTMLTrackElement.cpp b/Source/core/html/HTMLTrackElement.cpp
index 7dfe53d4a82b68a0450f2c6d1616ec327a1e643d..650a7c181a264224027f8a41f4bca1bd0b73b15b 100644
--- a/Source/core/html/HTMLTrackElement.cpp
+++ b/Source/core/html/HTMLTrackElement.cpp
@@ -60,8 +60,6 @@ inline HTMLTrackElement::HTMLTrackElement(Document& document)
HTMLTrackElement::~HTMLTrackElement()
{
- if (m_track)
Mads Ager (chromium) 2014/04/22 13:07:15 We should probably be careful and wrap this in #if
sof 2014/04/22 14:02:48 I don't mind putting it back in (even if I risk ge
Mads Ager (chromium) 2014/04/22 14:17:59 What if it has a JavaScript wrapper which also kee
- m_track->clearTrackElement();
}
PassRefPtr<HTMLTrackElement> HTMLTrackElement::create(Document& document)
@@ -272,4 +270,10 @@ HTMLMediaElement* HTMLTrackElement::mediaElement() const
return 0;
}
+void HTMLTrackElement::trace(Visitor* visitor)
+{
+ visitor->trace(m_track);
+ HTMLElement::trace(visitor);
+}
+
}

Powered by Google App Engine
This is Rietveld 408576698