Source/core/html/track/LoadableTextTrack.cpp - Issue 244493002: Oilpan: add transition types to track interface objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/LoadableTextTrack.cpp

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/track/InbandTextTrack.cpp ('K') | « Source/core/html/track/InbandTextTrack.cpp ('k') | Source/core/html/track/TextTrack.h » ('j') | Source/core/html/track/TextTrack.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/track/LoadableTextTrack.cpp

diff --git a/Source/core/html/track/LoadableTextTrack.cpp b/Source/core/html/track/LoadableTextTrack.cpp

index 66e6b8dcb9778bc87526cfdd89fb5cbc753c020b..0054042efc93ca5ef87c97f8f718b93db2b40edf 100644

--- a/Source/core/html/track/LoadableTextTrack.cpp

+++ b/Source/core/html/track/LoadableTextTrack.cpp

@@ -111,7 +111,7 @@ void LoadableTextTrack::newCuesAvailable(TextTrackLoader* loader)

{

ASSERT_UNUSED(loader, m_loader == loader);

- Vector<RefPtr<VTTCue> > newCues;

+ WillBeHeapVector<RefPtrWillBeMember<VTTCue> > newCues;

m_loader->getNewCues(newCues);

if (!m_cues)

@@ -119,7 +119,7 @@ void LoadableTextTrack::newCuesAvailable(TextTrackLoader* loader)

for (size_t i = 0; i < newCues.size(); ++i) {

newCues[i]->setTrack(this);

- m_cues->add(newCues[i]);

+ m_cues->add(newCues[i].release());

}

if (mediaElement())

@@ -140,7 +140,7 @@ void LoadableTextTrack::newRegionsAvailable(TextTrackLoader* loader)

{

ASSERT_UNUSED(loader, m_loader == loader);

- Vector<RefPtr<VTTRegion> > newRegions;

+ WillBeHeapVector<RefPtrWillBeMember<VTTRegion> > newRegions;

m_loader->getNewRegions(newRegions);

for (size_t i = 0; i < newRegions.size(); ++i) {

« Source/core/html/track/InbandTextTrack.cpp ('K') | « Source/core/html/track/InbandTextTrack.cpp ('k') | Source/core/html/track/TextTrack.h » ('j') | Source/core/html/track/TextTrack.h » ('J')