Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: Source/bindings/v8/Dictionary.cpp

Issue 244493002: Oilpan: add transition types to track interface objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add crbug.com/365260 crashing test + expectation Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 bool Dictionary::get(const String& key, RefPtr<MediaKeyError>& value) const 453 bool Dictionary::get(const String& key, RefPtr<MediaKeyError>& value) const
454 { 454 {
455 v8::Local<v8::Value> v8Value; 455 v8::Local<v8::Value> v8Value;
456 if (!getKey(key, v8Value)) 456 if (!getKey(key, v8Value))
457 return false; 457 return false;
458 458
459 value = V8MediaKeyError::toNativeWithTypeCheck(m_isolate, v8Value); 459 value = V8MediaKeyError::toNativeWithTypeCheck(m_isolate, v8Value);
460 return true; 460 return true;
461 } 461 }
462 462
463 bool Dictionary::get(const String& key, RefPtr<TrackBase>& value) const 463 bool Dictionary::get(const String& key, RefPtrWillBeMember<TrackBase>& value) co nst
464 { 464 {
465 v8::Local<v8::Value> v8Value; 465 v8::Local<v8::Value> v8Value;
466 if (!getKey(key, v8Value)) 466 if (!getKey(key, v8Value))
467 return false; 467 return false;
468 468
469 TrackBase* source = 0; 469 TrackBase* source = 0;
470 if (v8Value->IsObject()) { 470 if (v8Value->IsObject()) {
471 v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(v8Value); 471 v8::Handle<v8::Object> wrapper = v8::Handle<v8::Object>::Cast(v8Value);
472 472
473 // FIXME: this will need to be changed so it can also return an AudioTra ck or a VideoTrack once 473 // FIXME: this will need to be changed so it can also return an AudioTra ck or a VideoTrack once
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 751
752 return *this; 752 return *this;
753 } 753 }
754 754
755 void Dictionary::ConversionContext::throwTypeError(const String& detail) 755 void Dictionary::ConversionContext::throwTypeError(const String& detail)
756 { 756 {
757 exceptionState().throwTypeError(detail); 757 exceptionState().throwTypeError(detail);
758 } 758 }
759 759
760 } // namespace WebCore 760 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/Dictionary.h ('k') | Source/core/html/HTMLMediaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698