Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: chrome/browser/ui/cocoa/infobars/infobar_controller.mm

Issue 2444923003: Some more pre-material cleanups (Closed)
Patch Set: also remove some layout constants Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/infobars/infobar_controller.mm
diff --git a/chrome/browser/ui/cocoa/infobars/infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
index 2d14656cb35356c96af0f55a31891770862cdbb3..14e753a4639ab8fba0e6def91325d8edeeff23a8 100644
--- a/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
+++ b/chrome/browser/ui/cocoa/infobars/infobar_controller.mm
@@ -75,8 +75,8 @@
// Infobars are drawn a little taller, so have to move its controls to keep
// them centered.
- CGFloat heightDelta = InfoBarContainerDelegate::kDefaultBarTargetHeightMd -
- InfoBarContainerDelegate::kDefaultBarTargetHeight;
+ // TODO(ellyjones): Remove this constant.
Peter Kasting 2016/10/24 23:49:56 Remove how?
Evan Stade 2016/10/25 16:22:56 I don't know exactly how (not familiar enough with
+ CGFloat heightDelta = 2;
for (NSView* nextSubview in [infoBarView_ subviews]) {
NSRect frame = [nextSubview frame];
frame.origin.y += heightDelta / 2;

Powered by Google App Engine
This is Rietveld 408576698