|
|
Created:
4 years, 1 month ago by Torne Modified:
4 years, 1 month ago CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail, esprehn Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ )
Reason for revert:
Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc.
Original issue's description:
> Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()
>
> To diagnose the cause of crashes on WebView.
>
> BUG=514141
>
> Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1
> Cr-Commit-Position: refs/heads/master@{#358295}
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=514141
Committed: https://crrev.com/75b542feeeae9067b91349606c9dc48a9f50dd58
Cr-Commit-Position: refs/heads/master@{#427095}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 21 (9 generated)
Created Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()
Description was changed from ========== Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} TBR=haraken@chromium.org,bashi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 ========== to ========== Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 ==========
Going to revert this as esprehn@ suggested in the bug; we know it's not an allocator issue now.
LGTM
The CQ bit was checked by torne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Too optimistic about a year-old patch applying in reverse, I guess. I'll upload a rebased revert :)
The CQ bit was checked by torne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2444913002/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by torne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 ========== to ========== Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 ========== to ========== Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 Committed: https://crrev.com/75b542feeeae9067b91349606c9dc48a9f50dd58 Cr-Commit-Position: refs/heads/master@{#427095} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/75b542feeeae9067b91349606c9dc48a9f50dd58 Cr-Commit-Position: refs/heads/master@{#427095}
Message was sent while issue was closed.
lgtm, thanks for reverting this! |