Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2444913002: Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (Closed)

Created:
4 years, 1 month ago by Torne
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail, esprehn
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() (patchset #3 id:40001 of https://codereview.chromium.org/1419023008/ ) Reason for revert: Asserts no longer necessary; the bug is due to blink reinitialisation (which is now prevented elsewhere) not an internal problem with PartitionAlloc. Original issue's description: > Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags() > > To diagnose the cause of crashes on WebView. > > BUG=514141 > > Committed: https://crrev.com/e0a8f09ae45e944615cacd795a05b6243e3573e1 > Cr-Commit-Position: refs/heads/master@{#358295} # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=514141 Committed: https://crrev.com/75b542feeeae9067b91349606c9dc48a9f50dd58 Cr-Commit-Position: refs/heads/master@{#427095}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Torne
Created Revert of Add RELEASE_ASSERT() for |bucket| in partitionAllocGenericFlags()
4 years, 1 month ago (2016-10-24 13:34:59 UTC) #1
Torne
Going to revert this as esprehn@ suggested in the bug; we know it's not an ...
4 years, 1 month ago (2016-10-24 13:35:49 UTC) #3
haraken
LGTM
4 years, 1 month ago (2016-10-24 13:37:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444913002/1
4 years, 1 month ago (2016-10-24 13:40:31 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/292146) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-10-24 13:42:49 UTC) #8
Torne
Too optimistic about a year-old patch applying in reverse, I guess. I'll upload a rebased ...
4 years, 1 month ago (2016-10-24 13:43:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444913002/40001
4 years, 1 month ago (2016-10-24 13:48:25 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301386)
4 years, 1 month ago (2016-10-24 16:50:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444913002/40001
4 years, 1 month ago (2016-10-24 17:02:08 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-24 17:53:54 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/75b542feeeae9067b91349606c9dc48a9f50dd58 Cr-Commit-Position: refs/heads/master@{#427095}
4 years, 1 month ago (2016-10-24 18:22:37 UTC) #20
bashi
4 years, 1 month ago (2016-10-24 23:56:29 UTC) #21
Message was sent while issue was closed.
lgtm, thanks for reverting this!

Powered by Google App Engine
This is Rietveld 408576698