components/nacl/zygote/nacl_fork_delegate_linux.cc - Issue 24449002: NaCl: Clean up how FDs are passed to nacl_helper instances on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/zygote/nacl_fork_delegate_linux.cc

Issue 24449002: NaCl: Clean up how FDs are passed to nacl_helper instances on Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup: move constants Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/zygote/nacl_fork_delegate_linux.cc

diff --git a/components/nacl/zygote/nacl_fork_delegate_linux.cc b/components/nacl/zygote/nacl_fork_delegate_linux.cc

index d94ad6b9fdfe5237b92fd6592eed54338da34a78..27b6a068e572555a444815c8eb074950f9d7c7b9 100644

--- a/components/nacl/zygote/nacl_fork_delegate_linux.cc

+++ b/components/nacl/zygote/nacl_fork_delegate_linux.cc

@@ -258,7 +258,7 @@ bool NaClForkDelegate::CanHelp(const std::string& process_type,

pid_t NaClForkDelegate::Fork(const std::vector<int>& fds) {

VLOG(1) << "NaClForkDelegate::Fork";

- DCHECK(fds.size() == kNaClParentFDIndex + 1);

+ DCHECK(fds.size() == kParentFDIndex + 1);

jln (very slow on Chromium) 2013/10/07 18:12:06 kNumPassedFds?

Mark Seaborn 2013/10/08 18:31:06 Done.

// First, send a remote fork request.

Pickle write_pickle;