Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: content/browser/media/session/media_session_android.h

Issue 2444833004: Decouple MediaSession/MediaSessionObserver from WebContents in Java[OBSOLETE, go to the combined CL] (Closed)
Patch Set: addressed nits from jam@ Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session_android.h
diff --git a/content/browser/media/session/media_session_android.h b/content/browser/media/session/media_session_android.h
new file mode 100644
index 0000000000000000000000000000000000000000..d49328e06638abf80f26a64c0ad0dbad42cf2594
--- /dev/null
+++ b/content/browser/media/session/media_session_android.h
@@ -0,0 +1,55 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_ANDROID_H_
+#define CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_ANDROID_H_
+
+#include <jni.h>
+#include <memory>
+#include <vector>
+
+#include "base/android/scoped_java_ref.h"
+#include "content/public/browser/media_session_observer.h"
+
+namespace content {
+
+class MediaSessionImpl;
+
+bool RegisterMediaSessionNatives(JNIEnv* env);
+
+// This class is interlayer between native MediaSession and Java
+// MediaSession. This class is owned by the native MediaSession and will
+// teardown Java MediaSession when the native MediaSession is destroyed.
+// Java MediaSessionObservers are also proxied via this class.
+class MediaSessionAndroid final : public MediaSessionObserver {
+ public:
+ explicit MediaSessionAndroid(MediaSession* session);
+ ~MediaSessionAndroid() override;
+
+ static bool Register(JNIEnv* env);
mlamouri (slow - plz ping) 2016/10/28 10:24:50 style: move `static` above ctor and dtor
Zhiqiang Zhang (Slow) 2016/10/28 11:18:48 Done.
+
+ base::android::ScopedJavaLocalRef<jobject> GetJavaSession();
mlamouri (slow - plz ping) 2016/10/28 10:24:50 Maybe name it GetJavaObject() to match current pat
Zhiqiang Zhang (Slow) 2016/10/28 11:18:48 Done.
+
+ // MediaSessionObserver implementation.
+ void MediaSessionDestroyed() override;
+ void MediaSessionStateChanged(bool is_controllable,
+ bool is_suspended) override;
+ void MediaSessionMetadataChanged(
+ const base::Optional<MediaMetadata>& metadata) override;
+
+ // MediaSession method wrappers.
+ void Resume(JNIEnv* env, const base::android::JavaParamRef<jobject>& j_obj);
+ void Suspend(JNIEnv* env, const base::android::JavaParamRef<jobject>& j_obj);
+ void Stop(JNIEnv* env, const base::android::JavaParamRef<jobject>& j_obj);
+
+ private:
+ // The linked Java object
+ base::android::ScopedJavaGlobalRef<jobject> j_media_session_;
+
+ DISALLOW_COPY_AND_ASSIGN(MediaSessionAndroid);
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_MEDIA_SESSION_MEDIA_SESSION_ANDROID_H_

Powered by Google App Engine
This is Rietveld 408576698