X87: [full-codegen] Eliminate unnecessary hole checks for stores.

X87: [full-codegen] Eliminate unnecessary hole checks for stores.

  port 231c8ac0a78dd3d28f5398452c139062430ff008 (r40522)

  original commit message:
  Loads already used source position elimination to avoid unnecessary hole checks,
  but for reasons unknown stores did not. This CL corrects that, making full-codegen's
  hole elimination equivalent to ignition's.

  Also introduced a HoleCheckMode enum class to avoid more bool flags and updated
  VariableProxy and BytecodeGenerator appropriately.

BUG=

Committed: https://crrev.com/38939ff3e10aad73b46141acd28b56b145290e3d
Cr-Commit-Position: refs/heads/master@{#40527}

[zhengxing.li, 2016-10-24 09:06:15]

zhengxing.li@intel.com changed reviewers:
+ adamk@chromium.org, chunyang.dai@intel.com, weiliang.lin@intel.com

[zhengxing.li, 2016-10-24 09:06:16]

PTAL, thanks!

[Weiliang, 2016-10-24 10:06:53]

lgtm

[zhengxing.li, 2016-10-24 10:16:43]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2016-10-24 10:16:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 10:47:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-17 22:10:49]

Description was changed from

==========
X87: [full-codegen] Eliminate unnecessary hole checks for stores.

  port 231c8ac0a78dd3d28f5398452c139062430ff008 (r40522)

  original commit message:
  Loads already used source position elimination to avoid unnecessary hole
checks,
  but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
  hole elimination equivalent to ignition's.

  Also introduced a HoleCheckMode enum class to avoid more bool flags and
updated
  VariableProxy and BytecodeGenerator appropriately.

BUG=
==========

to

==========
X87: [full-codegen] Eliminate unnecessary hole checks for stores.

  port 231c8ac0a78dd3d28f5398452c139062430ff008 (r40522)

  original commit message:
  Loads already used source position elimination to avoid unnecessary hole
checks,
  but for reasons unknown stores did not. This CL corrects that, making
full-codegen's
  hole elimination equivalent to ignition's.

  Also introduced a HoleCheckMode enum class to avoid more bool flags and
updated
  VariableProxy and BytecodeGenerator appropriately.

BUG=

Committed: https://crrev.com/38939ff3e10aad73b46141acd28b56b145290e3d
Cr-Commit-Position: refs/heads/master@{#40527}
==========

[commit-bot: I haz the power, 2016-11-17 22:10:51]

Patchset 1 (id:??) landed as
https://crrev.com/38939ff3e10aad73b46141acd28b56b145290e3d
Cr-Commit-Position: refs/heads/master@{#40527}