Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc

Issue 2444813002: Remove unsafe mode to enable es3 api by default for WebGL2 and ES3 context (Closed)
Patch Set: remove runtime flag unsafeES3APIs from blink webgl module Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
index 5e5dcfbb20c1d14595bbd795382e50ca0d4d80ec..f39e932ca05ce704e1d73143788f6f4081598716 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
@@ -510,10 +510,10 @@ void GLES2DecoderTestBase::InitDecoderWithCommandLine(
DoCreateShader(GL_VERTEX_SHADER, client_shader_id_, kServiceShaderId);
// Unsafe commands.
- bool reset_unsafe_es3_apis_enabled = false;
- if (!decoder_->unsafe_es3_apis_enabled()) {
- decoder_->set_unsafe_es3_apis_enabled(true);
- reset_unsafe_es3_apis_enabled = true;
+ bool reset_es3_apis_enabled = false;
+ if (!decoder_->es3_apis_enabled()) {
+ decoder_->set_es3_apis_enabled(true);
+ reset_es3_apis_enabled = true;
}
const gl::GLVersionInfo* version = context_->GetVersionInfo();
@@ -536,8 +536,8 @@ void GLES2DecoderTestBase::InitDecoderWithCommandLine(
DoFenceSync(client_sync_id_, kServiceSyncId);
}
- if (reset_unsafe_es3_apis_enabled) {
- decoder_->set_unsafe_es3_apis_enabled(false);
+ if (reset_es3_apis_enabled) {
+ decoder_->set_es3_apis_enabled(false);
}
EXPECT_EQ(GL_NO_ERROR, GetGLError());

Powered by Google App Engine
This is Rietveld 408576698